On Tue, Apr 14, 2026 at 01:05:31PM +0200, William Lallemand wrote:
> Subject: Re: [PATCH 10/10] CI: Build halog as part of contrib.yml
> On Tue, Apr 14, 2026 at 11:50:40AM +0200, William Lallemand wrote:
> > Subject: Re: [PATCH 10/10] CI: Build halog as part of contrib.yml
> > On Tue, Apr 14, 2026 at 11:25:41AM +0200, William Lallemand wrote:
> > > Subject: Re: [PATCH 10/10] CI: Build halog as part of contrib.yml
> > > On Mon, Apr 13, 2026 at 09:23:47PM +0200, Tim Duesterhus wrote:
> > > > Subject: [PATCH 10/10] CI: Build halog as part of contrib.yml
> > > > halog does not make use of any of the "fancy" build flags that HAProxy 
> > > > does and
> > > > except for itself only includes ebtree. There is no need to build it as 
> > > > part of
> > > > the VTest workflows.
> > > 
> > > That's one of the thing that is tricky with these admin tools, they use .o
> > > previously built with haproxy if you don't do a make clean before. So for
> > > example if you have flags that are not compatible with the old objects 
> > > that
> > > won't work correctly. A typical example is building haproxy with ASAN and
> > > trying to link ASAN-enable objects with halog without the ASAN flags.
> > 
> > I'd prefer to keep this in the VTest workflow for now, this has been useful
> > several time.
> > 
> 
> I merged the whole series but the last patch.

I took a look again and deduplicated the VTest.yml which contained the
Test-musl job with almost the same steps.
https://github.com/haproxy/haproxy/commit/64d6c91c90c08f9c232fdecf3f08c86be5cf9236

In the end I took this patch about halog since we already have all the other
binaries in contrib.yml.

-- 
William Lallemand



Reply via email to