Le 24/06/2026 à 2:59 PM, Ronaldo Cheruiyot a écrit :
Hi everyone,
This patch adds support for the |no option forwardfor|directive, allowing users
to invert or unset default inherited options across proxy listening sections. It
fixes the configuration parser to accept |kwm|modifiers dynamically instead of
hardcoding a static state.
I have attached the |.patch| file generated by Git to this email.
Thanks, Ronaldo Cheruiyot
Thanks,
Unfortunately, your patch does not work. the option parsing must be moved upper,
in the part where other options supporting "no" prefix are handled.
Then, once fixed, it will work as expected. In your patch, when the "no" prefix
is set, fields of px->http_ext->xff are reset, while the xff structure must be
freed instead. At least it is my first guess without exploring the code deeper.
If you do some tests mixing the option between the frontend and the backend, you
will see strange behaviors, like a header inserted by with an empty name.
Then, you must update the documentation accordingly. Keep in mind that the "no"
prefix will only reset a value inherited from a default section or settings
already defined in the same proxy section. But it will not disable the feature.
If the option is defined on the frontend or the backend, the header will be
added, even if "disabled" on the other proxy section. It is important to be
clear on that because it may be confusing.
Finally, take care to add a message to your commit, not only a subject,
describing the change. And be carefull to remove all trailing space from you
changes.
Regards,
--
Christopher Faulet
