Sorry this wasn't obvious to me at first glance that this was to avoid the problem of our reg-tests script and vtest, I only understood it with the github ticket.
On Tue, Jun 30, 2026 at 05:02:06PM +0200, Илья Шипицин wrote: > Subject: Re: [PATCH] BUILD: add REGTESTS_KEEP_LOGS variable to preserve > regression test logs > sorry, I didn't catch the idea of pushing me to use "--" notation instead > of introducing variable. > > вт, 30 июн. 2026 г. в 16:39, William Lallemand <[email protected]>: > > > On Tue, Jun 30, 2026 at 04:38:25PM +0200, William Lallemand wrote: > > > Subject: Re: [PATCH] BUILD: add REGTESTS_KEEP_LOGS variable to preserve > > regression test logs > > > Hi Ilya, > > > > > > like I said in one of the github ticket related to this, we need to fix > > vtest > > > first, it's basically the consequence of the regressions we had because > > of the > > > method to display the skipped tests. *We should'nt* have to use > > --keep-logs or we > > > will be polluted with too much stuff, only what is breaking should emit > > logs. > > > > > > > *We should'nt* have to use --keep-logs or we... > > > > > > > On Tue, Jun 30, 2026 at 04:18:54PM +0200, Илья Шипицин wrote: > > > > Subject: Re: [PATCH] BUILD: add REGTESTS_KEEP_LOGS variable to > > preserve regression test logs > > > > gentle ping. > > > > a patch with "--" notation sent > > > > https://www.mail-archive.com/[email protected]/msg47204.html > > > > > > > > вт, 9 июн. 2026 г. в 20:25, William Lallemand <[email protected]>: > > > > > > > > > Hi Ilya, > > > > > > > > > > "--" is a standard shell argument, used by a lot of softwares, it's > > not > > > > > especially cryptic. I don't see any value in reemplementing arguments > > > > > in new variables, the feature are already there, we just have to use > > them. > > > > > > > > > > Regards, > > > > > > > > > > On Mon, Jun 08, 2026 at 02:00:10PM +0200, Илья Шипицин wrote: > > > > > > Subject: Re: [PATCH] BUILD: add REGTESTS_KEEP_LOGS variable to > > preserve > > > > > regression test logs > > > > > > gentle ping > > > > > > > > > > > > вт, 2 июн. 2026 г. в 11:47, Илья Шипицин <[email protected]>: > > > > > > > > > > > > > > > > > > > > > > > > > > > вс, 17 мая 2026 г. в 22:03, Willy Tarreau <[email protected]>: > > > > > > > > > > > > > >> On Sun, May 17, 2026 at 08:39:26PM +0200, ???? ??????? wrote: > > > > > > >> > make tries to interpret --keep-logs as own argument. didn't > > work > > > > > for me > > > > > > >> > > > > > > >> For all regtest options, you need to first pass -- to mark the > > end of > > > > > > >> "make" args. > > > > > > >> > > > > > > > > > > > > > > from my point of view, it is bad readability, one must know -- > > meaning > > > > > (I > > > > > > > didn't know) while variable name keeps readability. > > > > > > > > > > > > > > however, it is cosmetic, if you prefer cryptic -- notation, I > > don't > > > > > mind > > > > > > > to change that on the fly when applying > > > > > > > > > > > > > > > > > > > > >> > > > > > > >> willy > > > > > > >> > > > > > > > > > > > > > > > > > -- > > > > > William Lallemand > > > > > > > > > > > -- > > > William Lallemand > > > > -- > > William Lallemand > > -- William Lallemand
