Hi

with the end of life of HAProxy 2.4, all supported HAProxy versions support
the `-cc` flag to check the build configuration. This allows to simplify the
test runner logic by removing the "special comments" in favor of the robust
builtin feature.

Only "EXCLUDE_TARGET(S)" and "REGTEST_TYPE" remains now. I would've liked to
also remove the former, but from what I this this is not yet supported by -cc.
Using haproxy -v with a grep might be an option, because parsing the target is
reasonably simple compared to parsing the features. But perhaps it makes sense
to add a TARGET variable that can be checked with streq? I can imagine it might
also be useful for conditional configs as well.

Best regards

Tim Duesterhus (6):
  REGTESTS: Remove unused `add_range_to_test_list` function from
    `scripts/run-regtests.sh`
  REGTESTS: Remove unused `_version` function from
    `scripts/run-regtests.sh`
  REGTESTS: Migrate REQUIRE_OPTION to `haproxy -cc`
  REGTESTS: Remove support for `REQUIRE_OPTION` from
    scripts/run-regtests.sh
  REGTESTS: Migrate `REQUIRE_SERVICE=prometheus-exporter` to a
    `feature(PROMEX)` check
  REGTESTS: Remove support for `REQUIRE_SERVICE` from
    scripts/run-regtests.sh

 reg-tests/checks/healthcheck-section.vtc      |   2 +-
 reg-tests/checks/ssl-hello-check.vtc          |   2 +-
 reg-tests/checks/tcp-check-ssl.vtc            |   2 +-
 reg-tests/checks/tls_health_checks.vtc        |   2 +-
 reg-tests/compression/basic.vtc               |   2 +-
 reg-tests/compression/etags_conversion.vtc    |   2 +-
 reg-tests/compression/lua_validation.vtc      |   2 +-
 reg-tests/compression/min_size.vtc            |   2 +-
 reg-tests/compression/vary.vtc                |   2 +-
 reg-tests/connection/http_reuse_conn_hash.vtc |   2 +-
 .../connection/proxy_protocol_random_fail.vtc |   2 +-
 .../proxy_protocol_send_unique_id_alpn.vtc    |   2 +-
 reg-tests/contrib/prometheus.vtc              |   2 +-
 reg-tests/converter/digest.vtc                |   2 +-
 reg-tests/converter/hmac.vtc                  |   2 +-
 reg-tests/converter/secure_memcmp.vtc         |   2 +-
 reg-tests/converter/sha2.vtc                  |   2 +-
 reg-tests/filters/filter_sequence.vtc         |   2 +-
 reg-tests/filters/random-forwarding.vtc       |   2 +-
 reg-tests/lua/bad_http_clt_req_duration.vtc   |   2 +-
 reg-tests/lua/close_wait_lf.vtc               |   2 +-
 reg-tests/lua/h_txn_get_priv.vtc              |   2 +-
 reg-tests/lua/httpclient_action.vtc           |   2 +-
 reg-tests/lua/lua_httpclient.vtc              |   2 +-
 reg-tests/lua/lua_socket.vtc                  |   2 +-
 reg-tests/lua/set_var.vtc                     |   2 +-
 reg-tests/lua/txn_get_priv-thread.vtc         |   2 +-
 reg-tests/lua/txn_get_priv.vtc                |   2 +-
 reg-tests/lua/wrong_types_usage.vtc           |   2 +-
 reg-tests/mailers/healthcheckmail.vtc         |   2 +-
 reg-tests/peers/tls_basic_sync.vtc            |   2 +-
 .../peers/tls_basic_sync_wo_stkt_backend.vtc  |   2 +-
 reg-tests/quic/add_ssl_crt-list.vtc           |   2 +-
 reg-tests/quic/del_ssl_crt-list.vtc           |   2 +-
 reg-tests/server/cli_set_ssl.vtc              |   2 +-
 reg-tests/ssl/add_ssl_crt-list.vtc            |   2 +-
 reg-tests/ssl/del_ssl_crt-list.vtc            |   2 +-
 reg-tests/ssl/dynamic_server_ssl.vtc          |   2 +-
 reg-tests/ssl/set_ssl_bug_2265.vtc            |   2 +-
 reg-tests/ssl/set_ssl_cert.vtc                |   2 +-
 reg-tests/ssl/set_ssl_cert_noext.vtc          |   2 +-
 reg-tests/ssl/ssl_client_auth.vtc             |   2 +-
 reg-tests/ssl/ssl_frontend_samples.vtc        |   2 +-
 reg-tests/ssl/ssl_server_samples.vtc          |   2 +-
 reg-tests/ssl/ssl_simple_crt-list.vtc         |   2 +-
 reg-tests/ssl/wrong_ctx_storage.vtc           |   2 +-
 scripts/run-regtests.sh                       | 110 +-----------------
 47 files changed, 49 insertions(+), 153 deletions(-)

-- 
2.54.0



Reply via email to