>> * harbour/utils/hbformat/hbformat.prg >> ! fixed class method declarations to be synced with method implementations >> All of the above missdeclarations were detected by compilation with: >> HB_USER_PRGFLAGS=-DHB_CLS_PARAMS_ERR >> Few years ago in hbclass.ch I defined PP rules to force strict method >> declarations but I had to disable them due to problems with old PP. >> I defined HB_CLS_NO_PARAMS_ERR and left this note in hbclass.ch: >>> I have to enable this definition by default until we will not fix >>> preprocessor. [druzus] >> Current PP code works correctly so we can remove it and activate this >> code. Anyhow as above commit shows a lot of code has been created with >> wrong declarations. I fixed Harbour core code (except HBQT, HBXBP and >> GTWVG - I hope Pritpal or Viktor will fix it) but setting >> HB_CLS_PARAMS_ERR as default will exploit a lot of similar problems in >> user code so I would like the hear other developers' opinions about it. > > I support everything which helps creating better quality code, > so I agree to keep it enabled.
I just read it more carefully and understood it's not enabled yet, so my vote is to enable it now. The fix is easy, similar to -w3 warnings, it just has to be done, and such fix doesn't have any drawbacks. Brgds, Viktor _______________________________________________ Harbour mailing list (attachment size limit: 40KB) Harbour@harbour-project.org http://lists.harbour-project.org/mailman/listinfo/harbour
