On 13-09-02 06:41 AM, Khaled Hosny wrote: > On Fri, Aug 09, 2013 at 06:42:20AM -0700, Behdad Esfahbod wrote: >> commit 10f964623f003c70f6bdd33423420abda3820ce0 >> Author: Behdad Esfahbod <beh...@behdad.org> >> Date: Fri Aug 9 09:40:01 2013 -0400 >> >> Round when scaling values >> >> Doesn't matter for most users since they should be working in a >> fixed sub-pixel scale anyway (ie. 22.10, 26.6, 16.16, etc). > > With this commit, I’m seeing one pixel differences in my test suit, > things like (with Amiri): > > expected: > [uni06DD+2620|one.small@-2210,0+0|two.small@-1610,0+0|three.small@-1010,0+0] > result: > [uni06DD+2620|one.small@-2209,0+1|two.small@-1609,0+1|three.small@-1009,0+1] > > Looks harmless, but wanted to double check before updating the expected > output.
Are you shaping at upem size? If yes, then the change may be a bug. I don't have sortsmill so can't test. If Uniscribe returns the old value then this is definitely a bug. Feel free to suggest a patch. Or we can just revert. BTW, is Amiri still on SF, or github? If it's on github, may be a good idea to set it up on travis-ci.org, then add a hook from harfbuzz github to trigger amiri tests on travis, and send failure reports to harfbuzz list. Same about any other font projects that test against harfbuzz BTW! > Regards, > Khaled > -- behdad http://behdad.org/ _______________________________________________ HarfBuzz mailing list HarfBuzz@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/harfbuzz