FYI: I noticed a few minor things that we should probably fix in this contribution, but they don't break the build and it makes sense to commit the contribution as we received it then fix it up in 'business as usual' development.
Regards, Tim Tim Ellison (JIRA) wrote: > [ http://issues.apache.org/jira/browse/HARMONY-88?page=all ] > > Tim Ellison resolved HARMONY-88: > -------------------------------- > > Resolution: Fixed > > Thanks George & Mark, > > I've committed the contribution at repo revision 386087. > > Please check that it was applied as you expected. > > >> Contribution of code and unit tests for jndi, logging, prefs and sql plus >> unit tests only for beans, crypto, math, regex and security >> -------------------------------------------------------------------------------------------------------------------------------------- >> >> Key: HARMONY-88 >> URL: http://issues.apache.org/jira/browse/HARMONY-88 >> Project: Harmony >> Type: New Feature >> Components: Contributions >> Environment: Win32 and Linux >> Reporter: George Harley >> Assignee: Tim Ellison >> Attachments: 01.harmony.88.integration.sh, 01.harmony.88.integration.sh, >> 02.harmony.88.integration.diff, 02.harmony.88.integration.diff, >> Harmony-Contribution.zip >> >> Zip file containing implementation and unit test code for the following >> Harmony >> components : >> * jndi >> * logging >> * prefs >> * sql >> In addition there is unit test code only for the following Harmony >> components : >> * beans >> * crypto >> * math >> * regex >> * security >> The contents of this zip have been laid out with the current classlib >> directory >> structure of the Apache Harmony SVN repository in mind. A version of >> enhanced/classlib/trunk/make/build-java.xml is included containing new Ant >> targets to compile the new implementation plus tests code, and then run the >> tests. >> Native code, plus makefiles are included to build a shared library that is >> required to support the prefs implementation on the win.IA32 platform. >> Not all of the unit test classes are capable of being compiled when the Ant >> target "compile-tests" in <EXTRACT_DIR>/Harmony/make/build-java.xml is run. >> This >> is because the current contents of the Harmony trunk do not satisfy all of >> the >> dependencies of some classes. This issue affects the unit test code for the >> following set of components ... >> * beans (needs beans implementation in trunk) >> * crypto (needs crypto implementation in trunk) >> * logging (needs beans implementation in trunk) >> * jndi (needs applet implementation in trunk) >> * sql (needs rmi implementation in trunk) >> As a temporary measure, the lines of Ant script in >> <EXTRACT_DIR>/Harmony/make/build-java.xml that compile the above test code >> have been commented out with explanations. > -- Tim Ellison ([EMAIL PROTECTED]) IBM Java technology centre, UK.
