Thanks, Stepan for fixing that

2006/4/13, Mark Hindess <[EMAIL PROTECTED]>:
> Can you not fix it anyway?  Please.  It's a trivial refactoring.
>
> Regards,
>  Mark.
>
>
> On 4/13/06, Mikhail Loenko <[EMAIL PROTECTED]> wrote:
> > I do not have one :)
> >
> > Will try...
> >
> > Thanks,
> > Mikhail
> >
> > 2006/4/13, Mark Hindess <[EMAIL PROTECTED]>:
> > > And with the Sun compiler?  It should be trivial to reproduce.
> > >
> > > -Mark.
> > >
> > > On 4/13/06, Mikhail Loenko <[EMAIL PROTECTED]> wrote:
> > > > I've just created workspave from scratch and built it according to 
> > > > instructions.
> > > >
> > > > Everything passed.
> > > >
> > > > Windows XP, BEA 1.5
> > > >
> > > > Thanks,
> > > > Mikhail
> > > >
> > > > 2006/4/13, Oliver Deakin <[EMAIL PROTECTED]>:
> > > > > Thanks Mark
> > > > > This fixes the compilation problems I saw in ~1.java and ~2.java. I 
> > > > > can
> > > > > now run the crypto testsuite through in Windows ok with no failures. I
> > > > > will run the whole set of testsuites for all modules and post if I see
> > > > > anything similar elsewhere.
> > > > >
> > > > >
> > > > > Mark Hindess wrote:
> > > > > > This fixes the *1.java case:
> > > > > >
> > > > > > @@ -391,9 +391,13 @@
> > > > > >                  }
> > > > > >              }
> > > > > >              try {
> > > > > > -                skF[i].getKeySpec(secKeySpec,
> > > > > > -                        (defaultAlgorithm.equals(defaultAlgorithm2)
> > > > > > -                                ? DESedeKeySpec.class : 
> > > > > > DESKeySpec.class));
> > > > > > +                Class c;
> > > > > > +                if (defaultAlgorithm.equals(defaultAlgorithm2)) {
> > > > > > +                    c = DESedeKeySpec.class;
> > > > > > +                } else {
> > > > > > +                    c = DESKeySpec.class;
> > > > > > +                }
> > > > > > +                skF[i].getKeySpec(secKeySpec, c);
> > > > > >                  fail("getKeySpec(secKey, Class):
> > > > > > InvalidKeySpecException must be thrown");
> > > > > >              } catch (InvalidKeySpecException e) {
> > > > > >              }
> > > > > >
> > > > > > Just looking at the 2.java case and will submit a JIRA with both.
> > > > > >
> > > > > > -Mark.
> > > > > >
> > > > > > On 4/13/06, Geir Magnusson Jr <[EMAIL PROTECTED]> wrote:
> > > > > >
> > > > > >> I think that would be a workaround once we understand the cause.
> > > > > >>
> > > > > >> geir
> > > > > >>
> > > > > >> Mikhail Loenko wrote:
> > > > > >>
> > > > > >>> We may compile the tests old way...
> > > > > >>>
> > > > > >>> Thanks,
> > > > > >>> Mikhail
> > > > > >>>
> > > > > >>> 2006/4/13, Mark Hindess <[EMAIL PROTECTED]>:
> > > > > >>>
> > > > > >>>> Excluding these two tests:
> > > > > >>>>
> > > > > >>>>  javax/crypto/SecretKeyFactoryTest1.java
> > > > > >>>>  javax/crypto/SecretKeyFactoryTest2.java
> > > > > >>>>
> > > > > >>>> then the compilation works.
> > > > > >>>>
> > > > > >>>> -Mark.
> > > > > >>>>
> > > > > >>>> On 4/13/06, Oliver Deakin <[EMAIL PROTECTED]> wrote:
> > > > > >>>>
> > > > > >>>>> Hi Mark,
> > > > > >>>>>
> > > > > >>>>> Ive just found the same thing while building the crypto tests 
> > > > > >>>>> in windows
> > > > > >>>>> using J9 50. All tests up to there are ok. The output I get is 
> > > > > >>>>> similar
> > > > > >>>>> to yours:
> > > > > >>>>>
> > > > > >>>>> compile.tests:
> > > > > >>>>>      [echo] Compiling CRYPTO tests from
> > > > > >>>>> C:\PROGRA~1\eclipse\workspace\classlib\modules\crypto\src\test\java
> > > > > >>>>>     [javac] Compiling 31 source files to
> > > > > >>>>> C:\PROGRA~1\eclipse\workspace\classlib\modules\crypto\bin\test
> > > > > >>>>>     [javac] An exception has occurred in the compiler (1.5.0). 
> > > > > >>>>> Please
> > > > > >>>>> file a bug
> > > > > >>>>>  at the Java Developer Connection
> > > > > >>>>> (http://java.sun.com/webapps/bugreport)  after
> > > > > >>>>>  checking the Bug Parade for duplicates. Include your program 
> > > > > >>>>> and the
> > > > > >>>>> following
> > > > > >>>>> diagnostic in your report.  Thank you.
> > > > > >>>>>
> > > > > >>>>> Ill take a look and see if I can find which class it's 
> > > > > >>>>> compiling at the
> > > > > >>>>> time.
> > > > > >>>>>
> > > > > >>>>> Regards,
> > > > > >>>>> Oliver
> > > > > >>>>>
> > > > > >>>>> Mark Hindess wrote:
> > > > > >>>>>
> > > > > >>>>>> If I do a clean checkout and run:
> > > > > >>>>>>
> > > > > >>>>>> ant -f make/depends.xml download
> > > > > >>>>>> ant -f make/build.xml
> > > > > >>>>>> ant -f make/build-test.xml compile-support
> > > > > >>>>>> cd modules/crypto
> > > > > >>>>>> ant -f make/build.xml test
> > > > > >>>>>>
> > > > > >>>>>> I get a compiler error.  I've tried using both an IBM 5.0 and 
> > > > > >>>>>> Sun 5.0
> > > > > >>>>>> compiler and get the same error:
> > > > > >>>>>>
> > > > > >>>>>>   An exception has occurred in the compiler (1.5.0_06). Please 
> > > > > >>>>>> file a
> > > > > >>>>>> bug at the Java Developer Connection
> > > > > >>>>>> (http://java.sun.com/webapps/bugreport)  after checking the 
> > > > > >>>>>> Bug Parade
> > > > > >>>>>> for duplicates. Include your program and the following 
> > > > > >>>>>> diagnostic in
> > > > > >>>>>> your report.  Thank you.
> > > > > >>>>>>
> > > > > >>>>>> I assume since everyone else is quietly working on adding 5.0 
> > > > > >>>>>> code
> > > > > >>>>>> that I am the only one with this problem?
> > > > > >>>>>>
> > > > > >>>>>> I'm about to try the same test under windows, but thought I'd 
> > > > > >>>>>> mention
> > > > > >>>>>> this hear first.
> > > > > >>>>>>
> > > > > >>>>>> Regards,
> > > > > >>>>>>  Mark.
> > > > > >>>>>>
> > > > > >>>>>> --
> > > > > >>>>>> Mark Hindess <[EMAIL PROTECTED]>
> > > > > >>>>>> IBM Java Technology Centre, UK.
> > > > > >>>>>>
> > > > > >>>>>> ---------------------------------------------------------------------
> > > > > >>>>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > > > >>>>>> To unsubscribe, e-mail: [EMAIL PROTECTED]
> > > > > >>>>>> For additional commands, e-mail: [EMAIL PROTECTED]
> > > > > >>>>>>
> > > > > >>>>>>
> > > > > >>>>>>
> > > > > >>>>>>
> > > > > >>>>> --
> > > > > >>>>> Oliver Deakin
> > > > > >>>>> IBM United Kingdom Limited
> > > > > >>>>>
> > > > > >>>>>
> > > > > >>>>> ---------------------------------------------------------------------
> > > > > >>>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > > > >>>>> To unsubscribe, e-mail: [EMAIL PROTECTED]
> > > > > >>>>> For additional commands, e-mail: [EMAIL PROTECTED]
> > > > > >>>>>
> > > > > >>>>>
> > > > > >>>>>
> > > > > >>>> --
> > > > > >>>> Mark Hindess <[EMAIL PROTECTED]>
> > > > > >>>> IBM Java Technology Centre, UK.
> > > > > >>>>
> > > > > >>>> ---------------------------------------------------------------------
> > > > > >>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > > > >>>> To unsubscribe, e-mail: [EMAIL PROTECTED]
> > > > > >>>> For additional commands, e-mail: [EMAIL PROTECTED]
> > > > > >>>>
> > > > > >>>>
> > > > > >>>>
> > > > > >>> ---------------------------------------------------------------------
> > > > > >>> Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > > > >>> To unsubscribe, e-mail: [EMAIL PROTECTED]
> > > > > >>> For additional commands, e-mail: [EMAIL PROTECTED]
> > > > > >>>
> > > > > >>>
> > > > > >>>
> > > > > >> ---------------------------------------------------------------------
> > > > > >> Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > > > >> To unsubscribe, e-mail: [EMAIL PROTECTED]
> > > > > >> For additional commands, e-mail: [EMAIL PROTECTED]
> > > > > >>
> > > > > >>
> > > > > >>
> > > > > >
> > > > > >
> > > > > > --
> > > > > > Mark Hindess <[EMAIL PROTECTED]>
> > > > > > IBM Java Technology Centre, UK.
> > > > > >
> > > > > > ---------------------------------------------------------------------
> > > > > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > > > > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > > > > > For additional commands, e-mail: [EMAIL PROTECTED]
> > > > > >
> > > > > >
> > > > > >
> > > > >
> > > > > --
> > > > > Oliver Deakin
> > > > > IBM United Kingdom Limited
> > > > >
> > > > >
> > > > > ---------------------------------------------------------------------
> > > > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > > > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > > > > For additional commands, e-mail: [EMAIL PROTECTED]
> > > > >
> > > > >
> > > >
> > > > ---------------------------------------------------------------------
> > > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > > > For additional commands, e-mail: [EMAIL PROTECTED]
> > > >
> > > >
> > >
> > >
> > > --
> > > Mark Hindess <[EMAIL PROTECTED]>
> > > IBM Java Technology Centre, UK.
> > >
> > > ---------------------------------------------------------------------
> > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > > For additional commands, e-mail: [EMAIL PROTECTED]
> > >
> > >
> >
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > For additional commands, e-mail: [EMAIL PROTECTED]
> >
> >
>
>
> --
> Mark Hindess <[EMAIL PROTECTED]>
> IBM Java Technology Centre, UK.
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>

---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to