It did when I submitted the patch. -Mark. On 4/21/06, Stepan Mishura <[EMAIL PROTECTED]> wrote: > Hi Mark, > > Do you mean that the test tests/api/javax/crypto/CipherTest.java passes on > you linux without classpath modification? > > Thanks, > Stepan. > > On 4/20/06, Mark Hindess <[EMAIL PROTECTED]> wrote: > > > > Without the classpath modifications then it works for me on linux. > > -Mark. > > > > > > On 4/20/06, Stepan Mishura <[EMAIL PROTECTED]> wrote: > > > On 4/20/06, Mark Hindess wrote: > > > > > > > > Stepan, > > > > > > > > In your original commit for HARMONY-315, you made this change: > > > > > > > > <classpath> > > > > <pathelement path="${hy.crypto.src.test.resources}"/> > > > > </classpath> > > > > > > > > I'm not sure how this relates to this JIRA > > > > > > > > > Right, it was better to separate updates. > > > > > > but it is this that breaks > > > > the test. Why not remove/fix this unrelated change rather than > > > > comment out the otherwise working test? > > > > > > > > > It is not quite correct. The tests passes on Windows but fails on Linux > > - > > > I'm going to investigate the difference. But if I remove these lines > > then it > > > will fail on Windows too. > > > > > > IMHO, we should avoid making unrelated changes in a single commit. > > > > > > > > < SNIP> > > > > -- > > Mark Hindess <[EMAIL PROTECTED]> > > IBM Java Technology Centre, UK. > > > > --------------------------------------------------------------------- > > Terms of use : http://incubator.apache.org/harmony/mailing.html > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > -- > Thanks, > Stepan Mishura > Intel Middleware Products Division > > ------------------------------------------------------ > Terms of use : http://incubator.apache.org/harmony/mailing.html > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > >
-- Mark Hindess <[EMAIL PROTECTED]> IBM Java Technology Centre, UK. --------------------------------------------------------------------- Terms of use : http://incubator.apache.org/harmony/mailing.html To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]