If that reason is detected in the OS, not in our code, why does it
make difference?
Do you mean that we should not just test our code but also make
sure it works well in any environment (including OS)? I'd buy that
but think in this case it is not a unit test and thus should be moved
to a separate suite.
Thanks,
Mikhail
2006/6/9, Santiago Gala <[EMAIL PROTECTED]>:
El jue, 01-06-2006 a las 22:26 +0700, Mikhail Loenko escribió:
> 2006/6/1, Geir Magnusson Jr <[EMAIL PROTECTED]>:
> >
> >
> > Mikhail Loenko wrote:
> > > 2006/6/1, Geir Magnusson Jr <[EMAIL PROTECTED]>:
> > >>
> > >> I don't quite grok what you mean - could you post what you are
> > >> suggesting in code here on -dev?
> > >
> > >
> > > Index: modules/luni/src/test/java/tests/api/java/net/Inet6AddressTest.java
> > > ===================================================================
> > > ---
> > > modules/luni/src/test/java/tests/api/java/net/Inet6AddressTest.java
> > > (revision
> > > 410480)
> > > +++
> > > modules/luni/src/test/java/tests/api/java/net/Inet6AddressTest.java
> > > (working
> > > copy)
> > > @@ -785,7 +785,7 @@
> > > "FFFF:FFFF:FFFF:FFFF:FFFF:FFFF:255.255.255.255",
> > > "0:0:0:0:0:0:0:0", "0:0:0:0:0:0:0.0.0.0" };
> > >
> > > - String invalidIPAddresses[] = { ":", "FFFF:FFFF", "1:1",
> > > "::1.2.3.444" };
Not the code author, but the last address is illegal for a different
reason to the others, specifically because 444>255 and only because of
this.
Regards
Santiago
> > > + String invalidIPAddresses[] = { "FFFF:FFFF" };
> > >
> > > for (int i = 0; i < validIPAddresses.length; i++) {
> > >
> > >
> >
> > Thx - why do you want to remove testing the others? Because you believe
> > that it is in effect testing the resolver in the OS since each returns
> > the same answer,and thus it's testing the same thing over and over?
>
> I believe so, but I'd like to hear confirmation from code authors
>
> Thanks,
> Mikhail
>
>
> >
> > If so, I agree with you.
> >
> > If not, I still don't grok the point :)
> >
> > geir
> >
> >
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > For additional commands, e-mail: [EMAIL PROTECTED]
> >
> >
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
--
VP and Chair, Apache Portals (http://portals.apache.org)
Apache Software Foundation
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)
iD8DBQBEiGiRZAeG2a2/nhoRAhEQAKCh2XU75nmRtUY75I0faZu9a6/M4QCggaJX
JayynGPTdwg8+3NAp1DnPKk=
=ZwHY
-----END PGP SIGNATURE-----
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
