That would work but doesn't solve cmd line prop propogation... Still, better than nothing...
Why do we do it the way we do? Geir (from fone...) -----Original Message----- From: Mark Hindess [mailto:[EMAIL PROTECTED] Sent: Saturday, June 24, 2006 01:49 PM Pacific Standard Time To: harmony-dev@incubator.apache.org; [EMAIL PROTECTED] Subject: [classlib] build.properties (was Re: svn commit: r416344 ...) How about adding: <property file="build.properties" /> to make/properties.xml? Regards, Mark. On 22 June 2006 at 20:21, Geir Magnusson Jr <[EMAIL PROTECTED]> wrote: > not quite what I meant. > > I want to be able to have a "build.properties" file in by /trunk > directory that is personal, not checked in, that lets me override stuff. > > I was playing with it by adding a > > <property file="build.properties" /> > > before the <import> in build.xml, and the problem seems to be that our > invocation of build-java is "inheritall="false"" and then we read the > properties.xml file again in the build-java file, and it seems that a > <propertyset> in the <ant> in build.xml doesn't go through. The <import> > in build-java kills it? > > One way I thought of is to do a > > <property file="build.properties" /> > > in build-java.xml as well right before the <import> and that works. > > However, having to do this down the chain smells wrong, but I guess > we're doing it w/ the <import>. I don't understand the idea behind it > (my ant sk1lz are rusty) so I'm hoping someone can shine some light here... > > geir > > > Tim Ellison wrote: > > Sure -- done in r416469. > > > > Regards, > > Tim > > > > Geir Magnusson Jr wrote: > >> should we make this a property with a default so we can set it arbitrarily > ? > >> > >> Not asking you to do it, but just wondering how people feel about having > >> that sort of thing... > >> > >> geir > >> > >> [EMAIL PROTECTED] wrote: > >>> Author: tellison > >>> Date: Thu Jun 22 05:14:48 2006 > >>> New Revision: 416344 > >>> > >>> URL: http://svn.apache.org/viewvc?rev=416344&view=rev > >>> Log: > >>> Reduce forked compilation VM memory requirements. > >>> > >>> Modified: > >>> incubator/harmony/enhanced/classlib/trunk/make/build-java.xml > >>> > >>> Modified: incubator/harmony/enhanced/classlib/trunk/make/build-java.xml > >>> URL: http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/tru > nk/make/build-java.xml?rev=416344&r1=416343&r2=416344&view=diff > >>> ========================================================================= > ===== > >>> --- incubator/harmony/enhanced/classlib/trunk/make/build-java.xml (origin > al) > >>> +++ incubator/harmony/enhanced/classlib/trunk/make/build-java.xml Thu Jun > 22 05:14:48 2006 > >>> @@ -80,7 +80,7 @@ > >>> description="Compile the source"> > >>> <mkdir dir="${build.output}" /> > >>> > >>> - <javac fork="yes" memoryInitialSize="512M" memoryMaximumSize="60 > 0M" > >>> + <javac fork="yes" memoryMaximumSize="384M" > >>> destdir="${build.output}" > >>> source="${hy.javac.source}" target="${hy.javac.target}" > >>> debug="${hy.javac.debug}"> > >>> > >>> > >>> > >>> > >> --------------------------------------------------------------------- > >> Terms of use : http://incubator.apache.org/harmony/mailing.html > >> To unsubscribe, e-mail: [EMAIL PROTECTED] > >> For additional commands, e-mail: [EMAIL PROTECTED] > >> > >> > > > > --------------------------------------------------------------------- > Terms of use : http://incubator.apache.org/harmony/mailing.html > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- Terms of use : http://incubator.apache.org/harmony/mailing.html To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- Terms of use : http://incubator.apache.org/harmony/mailing.html To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
