On 7/13/06, Mikhail Loenko <[EMAIL PROTECTED]> wrote:
I suggest that we: 1) avoid throwing exceptions from native code 2) don't parse exception messages in the code (use subclasses of exceptions when necessary)
If all exceptions are thrown by java code, I think we problem2 will not be existing. Thanks,
Mikhail 2006/7/13, Andrew Zhang <[EMAIL PROTECTED]>: > On 7/13/06, Jimmy, Jing Lv <[EMAIL PROTECTED]> wrote: > > > > Hi: > > > > I'd like to raise the topic on I18N of native code. As discussed > > about patch-815, we found there are exceptions thrown by native code > > with un-internationalized error message. > > > > To resolve this problem, there > > may be two solutions: > > > > 1) make native code return error code instead of throw exceptions, and > > let Java code deal with these errors. This seems pretty good, and also > > resolve such problems like 815, but require much more effort to refactor > > all native and Java codes. What's more, as some native methods do not > > return an integer at all, we may add an output parameter to them, at > > least for network-related luni/nio, there are about 10 methods like this. > > > May we add an output parameter "errorCode" in each method. > > 2) As it is still easy for native code to call Java code, so rewrite > > error-message-lookup native method to lookup internationalized message, > > e.g., call MsgUtil.getString(). This refactor may be easy, but to > > JIRA-815 and other message-dependent Java code, it do no help. So it > > still requires other refactoring, e.g., return error code in some > > situation like suggested in (1). > > > > Another solution can be: catch exceptions on Java code, replace its > > message, and throw out again, this may be too ugly, so I do not suggest > > so. > > > > Any suggestions? Thanks! > > > > -- > > > > Best Regards! > > > > Jimmy, Jing Lv > > China Software Development Lab, IBM > > > > --------------------------------------------------------------------- > > Terms of use : http://incubator.apache.org/harmony/mailing.html > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > -- > Andrew Zhang > China Software Development Lab, IBM > > --------------------------------------------------------------------- Terms of use : http://incubator.apache.org/harmony/mailing.html To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
-- Andrew Zhang China Software Development Lab, IBM
