Weldon Washburn wrote: > All, > > The following build mods will create a drlvm binary that can be used > to debug the Jitrino.JET write barriers. Rather than make everyone > suffer through long email chains, Alex and I collaborated offline.
When you do that, no one else can participate... try to do things like this here... > > The mods to drlvm/trunk/build/build.bat: > > --- build.bat (revision 421403) > +++ build.bat (working copy) > @@ -138,7 +138,7 @@ > ) > > REM Note: vm.jitrino is always complied in release mode, otherwise it > makes VM > debug too slow > -CALL "%ANT_COMMAND%" -f make/build.xml -Dvm.jitrino.cfg=release %* > +CALL "%ANT_COMMAND%" -f make/build.xml %* I think it's time to get rid of the build.bat/build.sh once and for all... Or simply just pass the args you need to the script. > > GOTO THEEND > > Mods to drlvm/trunk/build/make/components/vm/jitrino.xml > > <project name="vm.jitrino"> > - <target name="init"> > + <target name="init" depends="common_vm"> > <property name="build.depends" > value="extra.apr,vm.vmcore,vm.encoder" /> > <property name="outtype" value="shared" /> > <property name="libname" value="jitrino" /> > @@ -48,7 +48,8 @@ > <patternset id="java.classes.pattern" includes="empty_pattern"/> > > <!-- the compiler doesn't extend common compiler --> > - <compiler name="${build.cxx}" id="cpp.compiler"> > + <!-- compiler name="${build.cxx}" id="cpp.compiler" --> > + <compiler id="cpp.compiler" extends="common.cpp.compiler"> > > For some unknown reason, svn diff wants to report that every line has > changed in common_vm.xml. Probably something to do with carriage > return line feed. In any case the mods to > drlvm/trunk/build/make/targets/common_vm.xml. These are the same mods > that were reported in the email titled, "[DRLVM] questions about > "build.bat -DEBUILD_CFG=debug -DCXX=msvc". They are repeated here for > completeness: > > - <select os="win" cxx="msvc"> > <compilerarg value="/Od" /> > <compilerarg value="/MTd" /> > <compilerarg value="/D_DEBUG" /> > </select> > > A new "svn update" of both classlib and drlvm was downloaded this > morning. The above mods were applied. And, finally, a ""build.bat > -DEBUILD_CFG=debug -DCXX=msvc" was run. The binary is now debuggable > with MS Visual Studio. > > Question: Should the above be bundled up as a JIRA patch? > I think the goal should be allowing people interested in this mode to simply pass a sensible flag/property, such that for everyone else, there is no change. And no - you're a committer, so you can apply it. But please, make this one-off condition something that you trigger w/ a flag passed to build.bat/.sh (until we get rid of it), rather than something everyone has to deal with. geir --------------------------------------------------------------------- Terms of use : http://incubator.apache.org/harmony/mailing.html To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]