On 8/15/06, Paulex Yang (JIRA) <[EMAIL PROTECTED]> wrote:
[ http://issues.apache.org/jira/browse/HARMONY-1051?page=comments#action_12428052] Paulex Yang commented on HARMONY-1051: -------------------------------------- Andrew, I have some concern on this patch: 1. It has no regression test, I knew this regression may be a little complex, but it's still possible to mock a thread context loader to test the exceptional case.
We need a configuration file (.jar) in classpath to run the test for this case. In fact, all service provider class tests have the same requirement. The question comes out: which folder is the proper place to hold these jar files? I suggest <module>/src/test/resources/ or <module>src/test/resources/configuration/, just like serialization ser files. Any suggestions/comments/objections? Thanks! 2. The static field contextClassLoader is not thread safe,while the spec of
Charset require the thread safety. So would you please provide another patch for this? any problem, please let me know, thank you. > [classlib][nio_char] Use system classloader as an alternative to load charset provider classes when thread's context classloader fails to load them. > ---------------------------------------------------------------------------------------------------------------------------------------------------- > > Key: HARMONY-1051 > URL: http://issues.apache.org/jira/browse/HARMONY-1051 > Project: Harmony > Issue Type: Improvement > Components: Classlib > Reporter: Andrew Zhang > Assigned To: Paulex Yang > Attachments: Harmony-1051.diff > > > As we dicussed on the mailing list[1], using system classloader as an alternative to load charset provider classes when thread's context classloader fails to load them will be a good choice to follow RI while keeping compliant with spec. > I'll upload a patch for this improvement soon. > Thanks! > Best regards, > Andrew > [1] mailing list thread: [classlib][nio-charset] RI is inconsistent with spec when loading charset provider -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
-- Andrew Zhang China Software Development Lab, IBM
