Assume I'm the committer - how hard will my life be?
Let me ask - do you trust that simply applying the patch to current SVN
head is ok?
geir
Ivanov, Alexey A wrote:
Geir,
Any way I have to check that we can ignore these chunks, just to be sure
everything's in the way expected. So why not just remove them from the
patch, and make life of a committer a little bit easier?
Regards,
--
Alexey A. Ivanov
Intel Middleware Product Division
-----Original Message-----
From: Geir Magnusson Jr. [mailto:[EMAIL PROTECTED]
Sent: Thursday, August 31, 2006 2:45 PM
To: harmony-dev@incubator.apache.org
Subject: Re: [vote] HARMONY-1225 : Assorted fixes and enhancements for
AWT
and Swing
Please don't waste the time because I am not comfortable voting on
one code contribution, and committing something else.
If you just give me a list of all chunks that I can ignore, I'll be
eternally grateful...
geir
On Aug 31, 2006, at 2:52 AM, Ivanov, Alexey A wrote:
-----Original Message-----
From: Alexey Petrenko [mailto:[EMAIL PROTECTED]
Sent: Wednesday, August 30, 2006 7:04 PM
To: harmony-dev@incubator.apache.org; [EMAIL PROTECTED]
Subject: Re: [vote] HARMONY-1225 : Assorted fixes and enhancements
for
AWT
and Swing
Most (probably all) of the failures are "already applied" failures.
So additional patch has no sense here.
Alexey can just remove already applied chunks to not disturb the
patcher...
This is what I'm going to do.
Regards,
Alexey.
2006/8/30, Geir Magnusson Jr. <[EMAIL PROTECTED]>:
Ok, but the correct way here is probably not a completely new
patch,
but
one that can follow the original patch with fix-ups....
geir
Ivanov, Alexey A wrote:
Mark,
I'll clean up the patch from those fixes which were applied during
HTML
integration, and attach the new one.
A quick look shows that Sergey is right, and many Swing fixes have
been
applied already.
Regards,
Alexey.
--
Alexey A. Ivanov
Intel Middleware Product Division
-----Original Message-----
From: Mark Hindess [mailto:[EMAIL PROTECTED]
Sent: Wednesday, August 30, 2006 4:17 PM
To: harmony-dev@incubator.apache.org
Subject: Re: [vote] HARMONY-1225 : Assorted fixes and
enhancements
for
AWT
and Swing
On 30 August 2006 at 14:02, "Sergey Soldatov"
<[EMAIL PROTECTED]> wrote:
Actually all these rejects were integrated during Swing text
integration and they doesn't matter.
Ok, but it would still be more reassuring to have a clean patch.
Currently, the only way I'd be confident that the patch has been
consistently applied would be to check the rejects by hand. I'm
assuming those who create the patch could do this quicker than
any of committers.
-Mark.
On 8/30/06, Mark Hindess <[EMAIL PROTECTED]> wrote:
+1
However, I'd also like to hear the end of the dependency saga.
It would also be useful (when the vote is complete) to have an
up
to
date patch. The current patch has lots of rejects due to
"previously
applied" hunks, etc. It will be quite difficult to integrate
in
its
current state.
Regards,
Mark.
On 28 August 2006 at 1:50, Geir Magnusson Jr <[EMAIL PROTECTED]>
wrote:
All is in order and in SVN for Harmony-1225 wrt BCC and ACQ.
Please vote to accept or reject this set of patches and fixes
into
the
Apache Harmony class library :
[ ] + 1 Accept
[ ] -1 Reject (provide reason below)
Lets let this run a minimum of 3 days unless a) someone states
they
need
more time or b) we get all committer votes before then.
geir
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail:
[EMAIL PROTECTED]
For additional commands, e-mail:
[EMAIL PROTECTED]
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail:
[EMAIL PROTECTED]
For additional commands, e-mail:
[EMAIL PROTECTED]
--------------------------------------------------------------------
-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail:
[EMAIL PROTECTED]
For additional commands, e-mail:
[EMAIL PROTECTED]
--
Alexey A. Petrenko
Intel Middleware Products Division
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: harmony-dev-
[EMAIL PROTECTED]
--
Alexey A. Ivanov
Intel Middleware Product Division
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail:
[EMAIL PROTECTED]
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
