Stepan, I 've filed it as HARMONY-1491. As far as I understand someone should close it according to the latest "Non-bug differences from RI" policy.
Thanks, 2006/9/13, Stepan Mishura <[EMAIL PROTECTED]>:
On 9/13/06, Alexei Zakharov wrote: > > Ok, Stepan, in this case I suggest to leave the check and rise the > additional "Non-bug differences from RI" JIRA (I can do if no one > objects). I don't really think there are many applications that rely > on this silent RI behavior, and IMHO we should not care until we > encounter one. Agree. Go forward with JIRA. -Stepan. Regards, > > 2006/9/12, Stepan Mishura <[EMAIL PROTECTED]>: > > Just have found in java.beans package description: > > "Unless explicitly stated, null values or empty Strings are not valid > > parameters for the methods in this package. You may expect to see > exceptions > > if these parameters are used." > > > > So it is a bug in RI. > > > > -Stepan. > > > > On 9/12/06, Stepan Mishura wrote: > > > > > > Alexei, > > > > > > We have the following RI behaviour here: > > > 1) Constructor doesn't allow 'null' value and throws NPE > > > 2) setSource allow 'null' value > > > > > > This looks inconsistent - to assign soure null value we can not use > > > constuctor directly! > > > > > > Thanks, > > > Stepan. > > > > > > > > > On 9/12/06, Alexei Zakharov wrote: > > > > > > > > Hi Stepan, > > > > > > > > Thank you for your attention to my patch first of all. IMHO > everything > > > > is ok except for the null-check you add to the setSource() method. > It > > > > seems RI does not check for null in this case. At least your > > > > regression test fails on Sun JDK 1.5.0_06: > > > > > > > > No expected NullPointerException > > > > junit.framework.AssertionFailedError: No expected > NullPointerException > > > > at > > > > > org.apache.harmony.beans.tests.java.beans.PropertyEditorSupportTest.test_setSourceLjava_lang_Object > > > > (PropertyEditorSupportTest.java:291) > > > > > > > > Thanks, > > > > > > > > 2006/9/12, Stepan Mishura (JIRA) < [EMAIL PROTECTED]>: > > > > > [ http://issues.apache.org/jira/browse/HARMONY-1409?page=all ] > > > > > > > > > > Stepan Mishura updated HARMONY-1409: > > > > > ------------------------------------ > > > > > > > > > > Summary: [classlib][beans] add missing get/setSource methods to > > > > PropertyEditorSupport (was: [classlib][beans] PropertyEditorSupport > > > > cleanup) > > > > > > > > > > > [classlib][beans] add missing get/setSource methods to > > > > PropertyEditorSupport > > > > > > > > > > > ---------------------------------------------------------------------------- > > > > > > > > > > > > Key: HARMONY-1409 > > > > > > URL: > > > > http://issues.apache.org/jira/browse/HARMONY-1409 > > > > > > Project: Harmony > > > > > > Issue Type: Improvement > > > > > > Components: Classlib > > > > > > Environment: ws2003 > > > > > > Reporter: Alexei Zakharov > > > > > > Assigned To: Stepan Mishura > > > > > > Attachments: PropertyEditorSupport.patch > > > > > > > > > > > > > > > > > > Attached patch adds two missing API methods that were introduced > in > > > > Java 1.5 API. In addition to that all unnecessary javadoc comments > are > > > > removed (@author and etc.), the coding style is corrected. > > > > > > > > > > -- > > > > > This message is automatically generated by JIRA. > > > > > - > > > > > If you think it was sent incorrectly contact one of the > > > > administrators: > http://issues.apache.org/jira/secure/Administrators.jspa > > > > > - > > > > > For more information on JIRA, see: > > > > http://www.atlassian.com/software/jira > > ------------------------------------------------------ Terms of use : http://incubator.apache.org/harmony/mailing.html To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
-- Alexei Zakharov, Intel Middleware Product Division --------------------------------------------------------------------- Terms of use : http://incubator.apache.org/harmony/mailing.html To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
