I reattached the patch. Not sure this was the case Ivan talked about - launcher was trying to read() the whole file at once - but anyway now file contents is mmapped for parsing.
-- Alexey 2006/9/23, Geir Magnusson Jr. <[EMAIL PROTECTED]>:
Hopefully we'll know when we get the actual patch. geir On Sep 22, 2006, at 1:39 PM, Ivan Volosyuk wrote: > When 'stracing' loading of VM I saw quite inefficient way to load a > file from disk. Reading one byte at a time by read() call. If I'm not > mistaken it was this property file. Is this issue fixed in the JIRA? > (Just curious) > -- > Ivan > > On 9/22/06, Alexey Varlamov <[EMAIL PROTECTED]> wrote: >> Dear comitters, >> >> Please find the patch attached to HARMONY-1376 which fixes number of >> issues with "harmonyvm.properties": >> 1) Robust file parsing with any EOLs; >> 2) The buffer overflow; >> 3) Added support for %VM_DIR% tokens, now easy to add any others; >> 4) Command-line "-Xbootclasspath:" option now really overrides >> whole BCP. > > --------------------------------------------------------------------- > Terms of use : http://incubator.apache.org/harmony/mailing.html > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > --------------------------------------------------------------------- Terms of use : http://incubator.apache.org/harmony/mailing.html To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
--------------------------------------------------------------------- Terms of use : http://incubator.apache.org/harmony/mailing.html To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
