OK, thanks a lot. P.S. I have found your discussion about separate patches.
2006/9/27, Nathan Beyer <[EMAIL PROTECTED]>:
> -----Original Message----- > From: Tim Ellison [mailto:[EMAIL PROTECTED] > > Geir Magnusson Jr. wrote: > > > > On Sep 26, 2006, at 10:23 AM, Denis Kishenko wrote: > > > >> Geir, thanks for answer. > >> > >> As I understand committers don't run tests from issue's descriptions? > > > > Sometimes. But if a test can be provided, it makes things a lot easier > > on the committers, and improves chances of getting in. > > I agree -- and two patch files is just fine. > > Regards, > Tim I'll add another vote to two patch files. I do exactly what Geir said; apply the test patch, run the tests to see the failure, then apply the source patch to see how it fixes the issue. -Nathan > > >> 2006/9/26, Geir Magnusson Jr. <[EMAIL PROTECTED]>: > >>> I really, really like two patches as we discussed on a different > thread. > >>> > >>> That way, I can apply the test patch, show the bug, apply the source > >>> patch, show it's gone (and then screw up and not commit all the code > >>> in the patch ;) > >>> > >>> Tim was neutral, but didn't care, so there's no opposition to asking > >>> for two. > >>> > >>> geir > >>> > >>> On Sep 26, 2006, at 9:29 AM, Denis Kishenko wrote: > >>> > >>> > Sometime I make two different diff files (source and test patches), > >>> > sometime I make the single one. Does it make sense for committers? > >>> > > >>> > -------------------------------------------------------------------- > - > >>> > Terms of use : http://incubator.apache.org/harmony/mailing.html > >>> > To unsubscribe, e-mail: [EMAIL PROTECTED] > >>> > For additional commands, e-mail: harmony-dev- > [EMAIL PROTECTED] > >>> > > >>> > >>> > >>> --------------------------------------------------------------------- > >>> Terms of use : http://incubator.apache.org/harmony/mailing.html > >>> To unsubscribe, e-mail: [EMAIL PROTECTED] > >>> For additional commands, e-mail: [EMAIL PROTECTED] > >>> > >>> > >> > >> > >> --Denis M. Kishenko > >> Intel Middleware Products Division > >> > >> --------------------------------------------------------------------- > >> Terms of use : http://incubator.apache.org/harmony/mailing.html > >> To unsubscribe, e-mail: [EMAIL PROTECTED] > >> For additional commands, e-mail: [EMAIL PROTECTED] > >> > > > > > > --------------------------------------------------------------------- > > Terms of use : http://incubator.apache.org/harmony/mailing.html > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > -- > > Tim Ellison ([EMAIL PROTECTED]) > IBM Java technology centre, UK. > > --------------------------------------------------------------------- > Terms of use : http://incubator.apache.org/harmony/mailing.html > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- Terms of use : http://incubator.apache.org/harmony/mailing.html To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
-- Denis M. Kishenko Intel Middleware Products Division --------------------------------------------------------------------- Terms of use : http://incubator.apache.org/harmony/mailing.html To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
