Richard, I've attached a patch to resolve the issue [1] where I modified locale-dependent string comparisons with assertion the string returned is not empty.
Please try it. Regards, Alexey. [1] https://issues.apache.org/jira/browse/HARMONY-1893 -- Alexey A. Ivanov Intel Middleware Product Division >-----Original Message----- >From: Alexey Varlamov [mailto:[EMAIL PROTECTED] >Sent: Wednesday, October 18, 2006 2:06 PM >To: [email protected] >Subject: Re: [classlib][swing] test failure: >javax.swing.filechooser.FileSystemViewTest.testGetSystemTypeDescription > >[snip] >> >> > >> >I agree we remove the locale dependent assertions temporarily. >> >> On the other hand, these assertions merely check that file corresponds to >"File", and folder corresponds to "Folder" or "File Folder". >> We can check that the return value is not null and is not empty string, >at least temporarily. > >Yes, just perform this check more carefully. > >> >> Later we can implement locale switching, if we want to. > >If we will want it ever. > >> >> What do you think? >> >> Regards, >> Alexey. >> >> >> > >> >Best regards, >> >Richard >> > >> >> >> >> Regards, >> >> Alexey. >> >> >> >> P.S. See also related issue [2]: "j.s.filechooser.FileSystemViewTest >> >prompts to insert disk into drive A:". >> >> >> >> >> >> [1] https://issues.apache.org/jira/browse/HARMONY-1893 >> >> [2] https://issues.apache.org/jira/browse/HARMONY-1892 >> >> >> >> >> >> -- >> >> Alexey A. Ivanov >> >> Intel Middleware Product Division >> >> >> >> >> >> >-----Original Message----- >> >> >From: Richard Liang [mailto:[EMAIL PROTECTED] >> >> >Sent: Wednesday, October 11, 2006 12:06 PM >> >> >To: [email protected] >> >> >Subject: [classlib][swing] test failure: >> >> >>javax.swing.filechooser.FileSystemViewTest.testGetSystemTypeDescription >> >> > >> >> >Hello, >> >> > >> >> >The test fails "on Windows XP when the locale-setting is zh_CN. It's >> >> >because that "view.getSystemTypeDescription(file)" returns Chinese >> >> >words "文件" instead of "File". >> >> > >> >> >Could any one help to verify this issue? Thanks a lot. >> >> > >> >> >-- >> >> >Richard Liang >> >> >China Development Lab, IBM >> >> > >> >> >--------------------------------------------------------------------- >> >> >Terms of use : http://incubator.apache.org/harmony/mailing.html >> >> >To unsubscribe, e-mail: [EMAIL PROTECTED] >> >> >For additional commands, e-mail: harmony-dev- >[EMAIL PROTECTED] >> >> >> >> --------------------------------------------------------------------- >> >> Terms of use : http://incubator.apache.org/harmony/mailing.html >> >> To unsubscribe, e-mail: [EMAIL PROTECTED] >> >> For additional commands, e-mail: [EMAIL PROTECTED] >> >> >> >> >> > >> > >> >-- >> >Richard Liang >> >China Development Lab, IBM >> > >> >--------------------------------------------------------------------- >> >Terms of use : http://incubator.apache.org/harmony/mailing.html >> >To unsubscribe, e-mail: [EMAIL PROTECTED] >> >For additional commands, e-mail: [EMAIL PROTECTED] >> >> -- >> Alexey A. Ivanov >> Intel Middleware Product Division >> >> --------------------------------------------------------------------- >> Terms of use : http://incubator.apache.org/harmony/mailing.html >> To unsubscribe, e-mail: [EMAIL PROTECTED] >> For additional commands, e-mail: [EMAIL PROTECTED] >> >> > >--------------------------------------------------------------------- >Terms of use : http://incubator.apache.org/harmony/mailing.html >To unsubscribe, e-mail: [EMAIL PROTECTED] >For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- Terms of use : http://incubator.apache.org/harmony/mailing.html To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
