I removed the final modifiers; this only affected PngDecoder, GifDecoder and JpegDecoder. I missed the comments in the fields of JpegDecoder, that was my mistake.
There were only 3-4 other fields that were finalized. Your email mentioned "a lot of invalid modifications"; what are the other issues, specifically? -Nathan On 10/24/06, Nathan Beyer <[EMAIL PROTECTED]> wrote:
Where are the tests for these decoders? How did you determine that they no longer worked? I'll remove the final modifiers. -Nathan On 10/24/06, Oleg Khaschansky <[EMAIL PROTECTED]> wrote: > Hi, > > Rev. 465514 introduced a lot of invalid modifications to the > GifDecoder, PngDecoder and JpegDecoder. There were a number of fields > modified or initialized from the native code only, but they were > redeclared as final, so the decoders doesn't work properly any more. > > This revision has the following comment: > > Cleanup code > * Add if/else braces > * Add missing annotations > * Add type variables > * Use foreach loops > * etc > > I'd suggest to roll back this revision and redo the cleanup in the > more accurate way. > > Thanks, > Oleg >
