Alexey thanks for question, because I'm intereseted in this too
As I understand from your discession, for example suport class modules\awt\src\test\api\java\common\java\awt\geom\ShapeTestCase.java should be moved to modules\awt\src\test\support\java\org\apache\harmony\awt\geom\tests\support\ShapeTestCase.java Am I right? 2006/11/1, Ivanov, Alexey A <[EMAIL PROTECTED]>:
Thank you, Nathan, for your reply. I believe these classes can be put to a support package in the module rather than java.* and javax.* correspondingly. I need to try it. At the moment they are along with the tests. But we can't help use javax.swing.* for swing tests since most of them are designed to be run on bootclasspath. See also the related message: http://thread.gmane.org/gmane.comp.java.harmony.devel/16591/focus=16591 Regards, Alexey. -- Alexey A. Ivanov Intel Middleware Product Division >-----Original Message----- >From: Nathan Beyer [mailto:[EMAIL PROTECTED] >Sent: Wednesday, November 01, 2006 3:15 AM >To: harmony-dev@incubator.apache.org >Subject: Re: [testing][support] Where to place xxxTestCase support classes > >If the support classes aren't used outside of one module, then I would >put them in that module. Like the beans example mentioned. > >As for the package name, I would prefer to avoid the "java.*" and >"javax.*" package names whenever possible, so we can avoid classpath >issues. > >-Nathan > >On 10/31/06, Alexei Zakharov <[EMAIL PROTECTED]> wrote: >> FYI in beans we have the following folders for this purpose: >> src/test/support/java/org/apache/harmony/beans/tests/support >> src/test/support/java/org/apache/harmony/beans/tests/support/mock >> >> Thanks, >> >> 2006/10/31, Ivanov, Alexey A <[EMAIL PROTECTED]>: >> > Hi all, >> > >> > Both AWT and Swing modules have testing support classes. Some of them >> > are extensions of junit.framework.TestCase which provide some utility >> > methods for tests. To mention several: AWTTestCase, ShapeTestCase, >> > BasicSwingTestCase, SwingTestCase. There are test cases which extend >> > these classes. >> > There are also several classes which provide special mock objects, >> > fields, for example ViewTestHelpers, DefStyledDoc_Helpers. >> > >> > The question about support classes was discussed [1] but no decision >was >> > taken. >> > The bad thing about these classes is that: >> > * some are stored along with tests utilizing these classes >> > (modules/awt/src/test/api/java/common/java/awt/), >> > * some are stored in support folder >> > (support/src/test/java/javax/swing/). >> > >> > >> > I think we should decide where such classes are to be stored. And move >> > them appropriately. >> > >> > Comments, opinions? >> > >> > Regards, >> > Alexey. >> > >> > >> > [1] >> > http://thread.gmane.org/gmane.comp.java.harmony.devel/9487/focus=9561 >> > >> > P.S. Mikhail, did you add the text from the message above into any doc? >> >> >> -- >> Alexei Zakharov, >> Intel Enterprise Solutions Software Division >>
-- Denis M. Kishenko Intel Middleware Products Division
