+1
for committing

A declaration VmThreadHandle h; is converts to (void*) h;
Intel compiler doesn't understand type names in brackets.

This is a fix for http://issues.apache.org/jira/browse/HARMONY-1897
icl build on Windows failed

Thanks, Salikh. A good catch!

On 11/3/06, Salikh Zakirov <[EMAIL PROTECTED]> wrote:
Hi,

the following trivial patch fixes the gc_gen compilation problem
with Intel Compiler under Windows:

--- vm/gc_gen/src/common/gc_platform.h
+++ vm/gc_gen/src/common/gc_platform.h
@@ -29,7 +29,7 @@ #include <open/hythread_ext.h>

 #define USEC_PER_SEC INT64_C(1000000)

-#define VmThreadHandle (void*)
+#define VmThreadHandle void*
 #define VmEventHandle   hysem_t
 #define THREAD_OK       TM_ERROR_NONE


I did not file the JIRA since the fix is trivial and would be obvious fix to 
anyone
trying compile gc_gen with Intel Compiler on Windows.

Could anyone commit this fix?


Reply via email to