Guys, to get a consensus on the interfaces is very good, but this issue is not about interfaces. j.u.concurrent.atomic.AtomicLong in its original implementation has private native method: boolean VMSupportsCS8(), thus to work with original concurrent classes any VM should export following function: JNIEXPORT jboolean JNICALL Java_java_util_concurrent_atomic_AtomicLong_VMSupportsCS8(JNIEnv *, jclass);
So the question here is what is the best place to put this function declaration in. For now the most logical place in DRLVM for me is: vmcore/src/kernel_classes/native/org_apache_harmony_util_concurrent_Atomics.h But as soon as the rest of those functions may soon be replaced with accessors, probably it makes sense to choose different place. Any thought on what is best place to put this function to? Nik. On 11/8/06, Nathan Beyer <[EMAIL PROTECTED]> wrote:
Instead of continuing to add functionality to the DRLVM-specific Atomics class, I'd like to get a consensus on the Threads/Objects (include CAS operations) interfaces in luni-kernel. Then we can get DRLVM to implement these classes and the donated IBM VM to do the same so we can have concurrent support from both VMs. -Nathan On 11/7/06, Nikolay Kuznetsov <[EMAIL PROTECTED]> wrote: > please see the following JIRA issue for the missing function: > http://issues.apache.org/jira/browse/HARMONY-2086 > > Nik. > > On 11/7/06, Nikolay Kuznetsov <[EMAIL PROTECTED]> wrote: > > While I'm not familiar with j.u.concurrent build infrastructure, but > > the issue about missing native function is known and I'll file a jira > > and provide a fix today. > > > > Nik. > > > > > 1) Natives are missing. In particular, > > > java.util.concurrent.atomic.AtomicLong.VMSupportsCS8 looks like should be > > > implemented on VM side. > > > 2) ant test -Dbuild.module=concurrent does not work. The output is as > > > follows: > > > > > > support-jar: > > > [jar] Building jar: > > > C:\_work_\harmony\enhanced\classlib\trunk\deploy\build > > > \test\support.jar > > > > > > test-modules: > > > > > > test: > > > > > > full-report: > > > > > > BUILD FAILED > > > C:\_work_\harmony\enhanced\classlib\trunk\build.xml:167: The following error > > > occ > > > urred while executing this line: > > > C:\_work_\harmony\enhanced\classlib\trunk\make\build-test.xml:58: > > > C:\_work_\harm > > > ony\enhanced\classlib\trunk\build\test_report not found. > > > > > > Do I miss something important? > > > > > > -- > > > Pavel Pervov, > > > Intel Enterprise Solutions Software Division > > > > > > > > >
