2006/11/15, Ivanov, Alexey A <[EMAIL PROTECTED]>:
Stepan, all,
I've created a JIRA to document the incompatibility of
GapContent.replace().
Great!
What's the number? :)
There are several test cases added, and some of them are indirectly
related to replace(). There's also patch which fixes incompatibilities
of insertString() and remove().
By the way, HARMONY-1753 describes related problem which I suggest to
resolve as non-bug difference.
Regards,
--
Alexey A. Ivanov
Intel Enterprise Solutions Software Division
>-----Original Message-----
>From: Ivanov, Alexey A [mailto:[EMAIL PROTECTED]
>Sent: Thursday, November 09, 2006 12:44 PM
>To: harmony-dev@incubator.apache.org
>Subject: RE: svn commit: r472115 -
>/incubator/harmony/enhanced/classlib/trunk/modules/swing/src/main/java/
comm
>on/javax/swing/text/GapContent.java
>
>>-----Original Message-----
>>From: Stepan Mishura [mailto:[EMAIL PROTECTED]
>>Sent: Thursday, November 09, 2006 9:47 AM
>>To: harmony-dev@incubator.apache.org
>>Subject: Re: svn commit: r472115 -
>>/incubator/harmony/enhanced/classlib/trunk/modules/swing/src/main/java
/
>comm
>>on/javax/swing/text/GapContent.java
>>
>>On 11/8/06, Ivanov, Alexey A wrote:
>>>
>>> >-----Original Message-----
>>> >From: Stepan Mishura
>>> >Sent: Wednesday, November 08, 2006 4:09 PM
>>> >To: harmony-dev@incubator.apache.org
>>> >Subject: Re: svn commit: r472115 -
>>>
>>/incubator/harmony/enhanced/classlib/trunk/modules/swing/src/main/java
/
>>> comm
>>> >on/javax/swing/text/GapContent.java
>>> >
>>> >On 11/8/06, Ivanov, Alexey A wrote:
>>> >>
>>> >> Stepan,
>>> >>
>>> >> I must be missing something obvious...
>>> >> What kind of regression test do you expect?
>>> >
>>> >
>>> >My logic is quite straightforward: the best way to fix a decision
is
>to
>>> >create a regression test. For example, if another volunteer find
out
>>> that
>>> >Harmony implementation of GapContent differ from RI's and propose a
>>> patch
>>> >to
>>> >fix it will any test remind him (or committer) about the decision?
>>
>>
>>To summarize my position: I see no value in discussing compatibility
>issues
>>on harmony-dev if a discussion doesn't have any outcome (JIRA to
>document a
>>difference or a regression test to fix implementation behavior).
>
>IMHO, there are two JIRAs which document the issue: HARMONY-1809 and
>HARMONY-1975.
>
>I'll add another one to document the *incompatibility* in behaviour and
>add a small test case which will always fail on the RI (until a
>volunteer would make Harmony implementation compatible with RI in
>respect to GapContent.replace()).
>
>
>Thanks for your opinion, Stepan.
>
>
>Regards,
>Alexey.
>
>>
>>In our case evaluation of HARMONY-1809 and HARMONY-1975 showed a
>>difference with RI. So we should fix/document it. Does this fit to
>>'Good Issue Resolution Guideline'?
>>
>>If a volunteer wants to make Harmony implementation of
>>> GapContent.replace() compatible with RI, they will provide many
tests
>-
>>> to test all invalid and edge situations to ensure the behaviour is
>>> *compatible* - along with patch. And I see no reason to stop them.
>>
>>
>>Sure, no reason to stop.
>>
>>(However, I believe a volunteer will search JIRA for GapContent before
>>> starting this work. And then they face this bug.)
>>>
>>> On the other hand, I hardly imagine an application depends on this
>>> functionality. That's why I haven't fixed it myself.
>>
>>
>>IMHO, an assumption that there is no such application is not a reason
>for
>>not documenting the difference.
>>
>>>
>>> >In our case we decided not to follow RI and do nothing for invalid
>>> >parameters. So a regression test should verify that Harmony
silently
>>> >ignores
>>> >bad parameters.
>>>
>>> It may make sense.
>>
>>
>>From my experience it always makes sense to add a test (even simple
and
>>obvious).
>>
>>Thanks,
>>Stepan.
>>
>>>
>>> >BWT, HARMONY-1809 should be marked as "non-bug difference from RI".
>>>
>>> I'm against this.
>>>
>>> >
>>> >Thanks,
>>> >Stepan.
>>> >
>>> >What was done is the signature of the GapContent.replace had been
>>> >> changed so that it didn't contain 'throws BadLocationException'
>>> clause.
>>> >>
>>> >> What is a regression test to demonstrate? That
>BadLocationException
>>> is
>>> >> not thrown any more?
>>> >> Or do you insist on setting gapStart to -2 after call replace(-2,
>2,
>>> >> null, 0), so that any subsequent operation on GapContent
generates
>>> >> ArrayIndexOutOfBounds?
>>> >>
>>> >> Regards,
>>> >> Alexey.
>>> >>
>>> >>
>>> >> P.S. The discussion thread:
>>> >>
>>>
>http://thread.gmane.org/gmane.comp.java.harmony.devel/17837/focus=17837
>>> >> The related JIRA issues:
>>> >> https://issues.apache.org/jira/browse/HARMONY-1809
>>> >> https://issues.apache.org/jira/browse/HARMONY-1975
>>> >>
>>> >>
>>> >> --
>>> >> Alexey A. Ivanov
>>> >> Intel Middleware Product Division
>>> >>
>>> >>
>>> >> >-----Original Message-----
>>> >> >From: Stepan Mishura [mailto: [EMAIL PROTECTED] ]
>>> >> >Sent: Wednesday, November 08, 2006 9:12 AM
>>> >> >To: harmony-dev
>>> >> >Subject: Re: svn commit: r472115 -
>>> >>
>>>
>>/incubator/harmony/enhanced/classlib/trunk/modules/swing/src/main/java
/
>>> >> comm
>>> >> >on/javax/swing/text/GapContent.java
>>> >> >
>>> >> >Hi,
>>> >> >
>>> >> >Any chance to see regression test (that I asked for in
>>> HARMONY-1975)?
>>> >> :-)
>>> >> >
>>> >> >Thanks,
>>> >> >Stepan.
>>> >> >
>>> >> >>-----Original Message-----
>>> >> >>From: [EMAIL PROTECTED] [mailto: [EMAIL PROTECTED] ]
>>> >> >>Sent: Tuesday, November 07, 2006 7:50 PM
>>> >> >>To: [EMAIL PROTECTED]
>>> >> >>Subject: svn commit: r472115 -
>>> >>
>>>
>>>/incubator/harmony/enhanced/classlib/trunk/modules/swing/src/main/jav
a
>>> >> /com
>>> >> >m
>>> >> >
>>> >> >>on/javax/swing/text/GapContent.java
>>> >> >>
>>> >> >>Author: apetrenko
>>> >> >>Date: Tue Nov 7 05:50:07 2006
>>> >> >>New Revision: 472115
>>> >> >>
>>> >> >>URL: http://svn.apache.org/viewvc?view=rev&rev=472115
>>> >> >>Log:
>>> >> >>Patch for HARMONY-1809
>>> >> >>"[classlib][swing]javax.swing.text.GapContent.replace(int, int,
>>> >> >> java.lang.Object, int) throws unspescified
>BadLocationException"
>>> >> >>
>>> >> >>Modified:
>>> >> >>
>>> >>
>>>
>>>incubator/harmony/enhanced/classlib/trunk/modules/swing/src/main/java
/
>>> >> comm
>>> >> >o
>>> >> >>n/javax/swing/text/GapContent.java
>>> >> >>
>>> >> ><SNIP>
>>> >>
>>> >>
>>> >--
>>> >Stepan Mishura
>>> >Intel Middleware Products Division
>>> >------------------------------------------------------
>>> >Terms of use : http://incubator.apache.org/harmony/mailing.html
>>> >To unsubscribe, e-mail:
[EMAIL PROTECTED]
>>> >For additional commands, e-mail:
>[EMAIL PROTECTED]
>>>
>>> --
>>> Alexey A. Ivanov
>>> Intel Middleware Product Division
>>>
>>
>>
>>
>>--
>>Stepan Mishura
>>Intel Middleware Products Division
>>------------------------------------------------------
>>Terms of use : http://incubator.apache.org/harmony/mailing.html
>>To unsubscribe, e-mail: [EMAIL PROTECTED]
>>For additional commands, e-mail: [EMAIL PROTECTED]
>
>--
>Alexey A. Ivanov
>Intel Enterprise Solutions Software Division
