On Fri, 2011-01-28 at 09:58 +0000, Nicholas Clark wrote: > On Fri, Jan 28, 2011 at 10:33:22AM +1000, Michael G Schwern wrote: > > > And I've used Aegis. I've CHAMPIONED Aegis. This was version control > > DESIGNED around code reviews. You could not make a commit unless it built > > ok, > > added tests, passed tests and the previous revision failed the new tests. I > > thought this was the greatest thing since pegs on a BMX bike. > > So how does one actually commit a refactoring? > How do I write a test that fails under the previous, functionally identical > code base?
I remember Aegis. It somewhat predates the refactoring fashion. On a more practical level any significant refactoring risks the introduction of a bug (unless you have 100% coverage tests of course) so all you need to do is commit a test for the new bug with the refactor changeset. ;) Cheers, Martin
