[
https://issues.apache.org/jira/browse/HBASE-478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12594967#action_12594967
]
stack commented on HBASE-478:
-----------------------------
+1 on patch.
I did not test (Patch is stale for TRUNK I believe).
The 599 fixes all look reasonable to me.
I like changes where IOEs are converted to TableNotFoundExceptions where it
makes sense.
Going forward, doesn't have to be in this patch, we should consider new
exception superclass, one we don't retry so we don't have to do this kinda
thing in multiple places:
{code}
+ if (e instanceof TableNotFoundException ||
+ e instanceof TableNotDisabledException ||
+ e instanceof InvalidColumnNameException) {
+ throw e;
{code}
> offlining of table does not run reliably
> ----------------------------------------
>
> Key: HBASE-478
> URL: https://issues.apache.org/jira/browse/HBASE-478
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.2.0, 0.1.2, 0.1.1
> Reporter: stack
> Assignee: Jim Kellerman
> Priority: Critical
> Fix For: 0.2.0, 0.1.2
>
> Attachments: 478-0.1-v2.patch, 478-0.1.patch, 478-trunk.patch
>
>
> I have a table of 4 regions made w/ PE. I cannot reliably offline it. I'm
> using 'disable TestTable' and have traced it to ensure its not a problem in
> hql. What I see is that one region will get the offlined mark or maybe
> two.. but never all.
> Jim in IRC suggested that if we did the .TABLE. catalog table, offlining the
> entry there might be more reliable than trying to offline all regions in a
> table.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
