[
https://issues.apache.org/jira/browse/HBASE-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596641#action_12596641
]
stack commented on HBASE-23:
----------------------------
FYI, leave out the CHANGES.txt changes. Your patch will fail if someone has
made a commit ahead of yours.
I tried the patch. Looks really good. I love that we're now showing server
names and thanks for renaming catalog tables section.
Would suggest that no reason catalog tables shouldn't be clickable as user
tables are. Usually will be one region only but even so, the new Table page
shows where that region is located and gives a never-before available
quick-path to the hosting region server.
The Is Split column in the table will probably never be true especially when we
are doing this:
{code}
+ if (info.isOffline() || info.isSplit()) {
+ continue;
+ }
{code}
Would suggest you remove it (Sorry - -my fault for suggesting it in the first
place)
Would you mind fixing the requests calcuation? Its kinda weird at the moment.
Its requests per hbase.regionsserver.msginterval (default 3 seconds). It
should be showing requests per second. Thats what people expect.
On the code, FYI, the hadoop convention is two-spaces for tabs.
Regards your TODO, that you've duplicated code until we add MetaTable, thats
fine.
Was wondering if the .META. table was made of multiple regions and your scanner
had to cross from one to the other, do you handle that case?
Otherwise, the patch is great.
> UI listing regions should be sorted by address and show additional region
> state
> -------------------------------------------------------------------------------
>
> Key: HBASE-23
> URL: https://issues.apache.org/jira/browse/HBASE-23
> Project: Hadoop HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: stack
> Priority: Minor
> Fix For: 0.2.0
>
> Attachments: hbase-23-v1.patch, hbase-23-v2.patch
>
>
> Currently, looking at a cluster under load, you'll often trip over the
> disorientating listing of more than one region with a null end key (Was seen
> by Billy yesterday and psaab today). UI should list out all of its
> attributes.
> Also sort region listings by server address so easier finding servers.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
