[ 
https://issues.apache.org/jira/browse/HBASE-814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12621542#action_12621542
 ] 

stack commented on HBASE-814:
-----------------------------

Michael:

Whats the license on the json jar and where's the source?

Add an apache license to all of your new class files.

Would also suggest you add package-level documentation like the thrift 
packages.  Would help people get off the ground (Copy the wiki page down here?).

Otherwise patch looks excellent.




> JSON Rest Regular (No Transaction)
> ----------------------------------
>
>                 Key: HBASE-814
>                 URL: https://issues.apache.org/jira/browse/HBASE-814
>             Project: Hadoop HBase
>          Issue Type: New Feature
>          Components: rest
>            Reporter: Michael Gottesman
>         Attachments: patch.diff
>
>
> This is the first patch for JSONRest. It contains the non-transactional part 
> of JSONRest without the unit tests. Since JSONRest is very modular, the 
> transaction part of it is just an extension of normal JSONRest and is not 
> needed to use normal JSONRest
>  The unit tests are still being built and are not ready yet and so will be 
> submitted later (they work, the main issue is that I have been using faked 
> data with the perl faker module. I need to just generate a dataset and use 
> it. Sometimes gimicky cool things like generating random data for my tests 
> grab me... for better or worse).
> To emphasize this I have decided to submit 2 patches, JSONRest and 
> transactional JSONRest.
> I will attach the unit tests in a few days once they have been completed and 
> are in a form that Hudson can use them.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to