[
https://issues.apache.org/jira/browse/HBASE-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12662599#action_12662599
]
stack commented on HBASE-876:
-----------------------------
Evgeny:
I noticed that when I went from 3.3 eclipse to 3.4 (ganymede), it started
saying 'Unnecessary @SuppressWarnings("unused")' are unnecessary. You are
using ganymede eclipse? I'd say remove them.
On second warning type, I suppose we should do as suggested.
> There are a large number of Java warnings in HBase
> --------------------------------------------------
>
> Key: HBASE-876
> URL: https://issues.apache.org/jira/browse/HBASE-876
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.18.0
> Reporter: Jim Kellerman
> Assignee: Evgeny Ryabitskiy
> Priority: Minor
> Fix For: 0.20.0
>
>
> There are a large number of Java warnings in the current HBase code base
> including:
> - exceptions that do not define serialVersionUID
> - classes that use the raw type WritableComparable instead of
> WritableComparable<T>
> - classes or interfaces that declare public members that are not a part of
> the public API. In this case they should be moved to a place where their
> visibility needs not be public. Additionally, there are a number of classes
> that declare public members that need not be. Make them protected or private
> or default as needed
> - methods that have unnecessary else clauses
> - potential null pointer access
> - inner classes that are public that should be default or protected (e.g.
> RegionHistoryInformation)
> - assignment to an input parameter
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
