[ 
https://issues.apache.org/jira/browse/HBASE-1145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12675095#action_12675095
 ] 

stack commented on HBASE-1145:
------------------------------

Thanks for the comments on patch.  Helps reading the patch src.  Patch looks 
great.  One question, how do I override what hbase finds looking up hostname?   
Add to zoo.cfg an explicit address? (I just saw this +    String addressStr = 
conf.get(MASTER_ADDRESS);)

Regards this property, run.distributed, give it a hbase prefix; our stuff can 
be mixed in with hadoop and who ever else uses the hadoop Configuration system.

Regards this comment "Enable this to run a distributed HBase. When this is 
disabled
+    (the default) HBase runs all processes on the current host in a local 
mode.", if 'false', we don't read the regionservers file?

Can this be final since set in constructor?

+  private ZooKeeperWrapper zooKeeper;

You don't need a patched ZK jar to do this?

> Ensure that there is only 1 Master with Zookeeper
> -------------------------------------------------
>
>                 Key: HBASE-1145
>                 URL: https://issues.apache.org/jira/browse/HBASE-1145
>             Project: Hadoop HBase
>          Issue Type: Sub-task
>            Reporter: Jean-Daniel Cryans
>            Assignee: Nitay Joffe
>         Attachments: hbase-1145.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to