[
https://issues.apache.org/jira/browse/HBASE-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nitay Joffe updated HBASE-1262:
-------------------------------
Attachment: hbase-1262.patch
In this patch:
- Fix trivial cases where we call toString() on an array of bytes by calling
Bytes.toString().
- Add missing @Override annotations.
- Annotate deprecated methods with @Deprecated.
- Add javadoc comment with @see to parent method for overriding methods with
no comment.
- Fix existing javadoc comment tags.
- Add check for null and class type for equals() methods that assume the right
type.
- Remove unnecessary else clauses (e.g. when if returns/throws).
- Remove unnecessary casts.
- Fix methods assigning parameter names.
- FindBugs: Replace Integers being used as locks with Objects.
- FindBugs: Unsynchronized get method, synchronized set method.
- Replace myArray.hashCode() with Arrays.hashCode(myArray).
- Remove @SuppressWarnings("unused") where it's not needed.
- Implement Serializable for simple Comparators.
> Warning: Access to enclosing constructor X is emulated by a synthetic
> accessor method. Increasing its visibility will increase your performance.
> ------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-1262
> URL: https://issues.apache.org/jira/browse/HBASE-1262
> Project: Hadoop HBase
> Issue Type: Improvement
> Affects Versions: 0.19.0
> Reporter: Nitay Joffe
> Assignee: Nitay Joffe
> Priority: Trivial
> Fix For: 0.19.2
>
> Attachments: hbase-1262.patch, hbase-1262.patch
>
>
> We get this warning all over in many pieces of the code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
