[
https://issues.apache.org/jira/browse/HBASE-1304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709709#action_12709709
]
stack commented on HBASE-1304:
------------------------------
Tests look great (especially bit where pieces are tested individually instead
of as part of a minihbasecluster spinup). In fact, they are beautiful. I love
the fact that they go on and on.
This is a little odd:
+ private final boolean PRINT = false;
Just use a logger and emit output. Who cares.
These names on DeleteCompare seem odd but maybe they'll make sense when I get
to the class:
INCLUDE_NEW_NEXT_NEW
NEXT_NEW
Whats going on here?
{code}
+ List<KeyValue> l1 = new ArrayList<KeyValue>();
+ l1.add(new KeyValue(row1, fam1, col5, data));
+ l1.add(new KeyValue(row2, fam1, col1, data));
+ l1.add(new KeyValue(row2, fam1, col2, data));
+ scanners.add(new Scanner(l1));
{code}
Scanners take a list of KVs? Even though they have different rows?
Not important, just a thought --> Should KeyValueScanner implement java Queue
and be called KeyValueQueue altogther? next method becomes poll. The
unimplementables such as remove throw unimplemented exceptions.
Is there anything left in InternalScanner other than close?
I'm about 1/3rd of the way through. Thats enough for now. Will return to it
in morning.
> New client server implementation of how gets and puts are handled.
> -------------------------------------------------------------------
>
> Key: HBASE-1304
> URL: https://issues.apache.org/jira/browse/HBASE-1304
> Project: Hadoop HBase
> Issue Type: Improvement
> Affects Versions: 0.20.0
> Reporter: Erik Holstad
> Assignee: Jonathan Gray
> Priority: Blocker
> Fix For: 0.20.0
>
> Attachments: hbase-1304-v1.patch, HBASE-1304-v2.patch,
> HBASE-1304-v3.patch, HBASE-1304-v4.patch, HBASE-1304-v5.patch,
> HBASE-1304-v6.patch
>
>
> Creating an issue where the implementation of the new client and server will
> go. Leaving HBASE-1249 as a discussion forum and will put code and patches
> here.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
