[ 
https://issues.apache.org/jira/browse/HBASE-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12715091#action_12715091
 ] 

stack commented on HBASE-1465:
------------------------------

I've always hated @override (Just ask JK) but I think its better now that it 
used to be in that compiler will flag when no method is being overridden (I'm 
probably wrong here but I have some notion that compiler didn't flag in the 
past -- only recently has it begun to).  Still, the arguments for, to me, seem 
almost specious.  Summarizing the benefits as listed in link here, 
http://stackoverflow.com/questions/94361/when-do-you-use-javas-override-annotation-and-why,
 "litter your code everywhere with @override to guard against rare case where 
parent class method changes".

> Remove unnecessary @Overrides
> -----------------------------
>
>                 Key: HBASE-1465
>                 URL: https://issues.apache.org/jira/browse/HBASE-1465
>             Project: Hadoop HBase
>          Issue Type: Improvement
>    Affects Versions: 0.20.0
>            Reporter: Jonathan Gray
>            Assignee: Jonathan Gray
>            Priority: Trivial
>             Fix For: 0.20.0
>
>         Attachments: HBASE-1465-v1.patch
>
>
> Eclipse on my Mac is showing some errors when an @Override is used when a 
> class implements an interface rather than extends.
> Not a big deal but I want to keep this patch around anyways for personal use.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to