[ 
https://issues.apache.org/jira/browse/HBASE-1385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724947#action_12724947
 ] 

Lars George commented on HBASE-1385:
------------------------------------

bq. Is the split algorithm the same as old days? I suppose it is since not in 
this patch. 

Yes, apart from the change you did, i.e. setting the number of splits to the 
number of regions. Is there anything else that is not right with it?

One things I have to note is the odd Configurable approach apparently the 
Hadoop's #1 choice to assign the generic Configuration to a class. It requires 
to implement a getConf() as well as setConf(). The latter is then used to 
"configure" the instance as it is called like the old configure() method. It 
seems to be less intuitive and also the getConf() seems obsolete in most cases. 
But maybe this is just not fully polished in the Hadoop classes? 



> Revamp TableInputFormat, needs updating to match hadoop 0.20.x AND remove bit 
> where we can make < maps than regions
> -------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-1385
>                 URL: https://issues.apache.org/jira/browse/HBASE-1385
>             Project: Hadoop HBase
>          Issue Type: Bug
>            Reporter: stack
>             Fix For: 0.21.0
>
>         Attachments: 1385-v2.patch, 1385.patch, mr.patch
>
>
> Update TIF to match new MR.
> Remove the bit of logic where we will use number of configured maps as splits 
> count rather than regions.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to