[ 
https://issues.apache.org/jira/browse/HBASE-1671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12736177#action_12736177
 ] 

Jean-Daniel Cryans commented on HBASE-1671:
-------------------------------------------

+1

I did not test it but from what I see it does the right thing, also it adds a 
test case. Waiting for a scanner to finish before splitting is dangerous IMO, 
imagine a job that writes inside a table it scans... could take a long time 
before it finishes and we could get very big regions! So now with the client 
handling that we should have a better story.

Some nitpicks, some classes have unused imports after this patch like HCM and I 
also wonder why you use org.mortbay.log.Log inside ScannerCallable as we never 
used that class anywhere else.

> HBASE-1609 broke scanners riding across splits
> ----------------------------------------------
>
>                 Key: HBASE-1671
>                 URL: https://issues.apache.org/jira/browse/HBASE-1671
>             Project: Hadoop HBase
>          Issue Type: Bug
>            Reporter: stack
>             Fix For: 0.20.0
>
>         Attachments: 1671-v2.patch, 1671-v3.patch, 1671.patch
>
>
> On split, we close region and close out scanner leases.  Scanners coming in 
> get USEs instead of NSREs.  Fix.  Broke by hbase-1609.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to