[ 
https://issues.apache.org/jira/browse/HBASE-1717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jonathan Gray updated HBASE-1717:
---------------------------------

    Status: Patch Available  (was: Open)

Review for commit.  I think KV cloning is the way to go.  If we don't, then we 
need to be very explicit in the javadocs about when you need to be sure not to 
touch passed values.  With this patch, we don't have to say anything because it 
copies everything.

> Put on client-side uses passed-in byte[]s rather than always using copies
> -------------------------------------------------------------------------
>
>                 Key: HBASE-1717
>                 URL: https://issues.apache.org/jira/browse/HBASE-1717
>             Project: Hadoop HBase
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 0.20.0
>            Reporter: Jonathan Gray
>            Assignee: Jonathan Gray
>            Priority: Critical
>             Fix For: 0.20.0
>
>         Attachments: HBASE-1717-v1.patch
>
>
> During review of Put with ryan, found that we are using a passed in reference 
> to family in add() rather than a local copy.  If the backing array changed 
> values, this could cause trouble.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to