[ 
https://issues.apache.org/jira/browse/HBASE-1821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jonathan Gray updated HBASE-1821:
---------------------------------

    Attachment: HBASE-1821-v2.patch

Patch is influenced from Olariu's patch.  Thanks.

Building on it, we need to track both whether we hit the column at all, as well 
as whether we matched it successfully or not.

Adds a test to TestFilter that defines the behavior and shows how to achieve 
what was originally wanted.

One thing... If you want to prevent rows from showing up that don't have the 
column at all (rather than passed/failed the value check), you need to wrap 
them in a SkipFilter.  This is explained and defined in the test as well.

Also had to make two edits to the existing TestSCVF.  Once the filter hits the 
column and matches, it will always return true for further KVs.  This is from 
the optimization Olariu explained which is part of my patch as well.

Tests pass.  Please review.

> Filtering by SingleColumnValueFilter bug
> ----------------------------------------
>
>                 Key: HBASE-1821
>                 URL: https://issues.apache.org/jira/browse/HBASE-1821
>             Project: Hadoop HBase
>          Issue Type: Bug
>            Reporter: stack
>            Assignee: Jonathan Gray
>             Fix For: 0.20.1
>
>         Attachments: HBASE-1821-v2.patch, HBASE-1821.patch
>
>
> See up in hbase-user mailing list under title 'Filtering by 
> SingleColumnValueFilter'.  Adrian describes roughly how he fixed the issue 
> (And what he wanted the filter to do).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to