[
https://issues.apache.org/jira/browse/HBASE-1915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766972#action_12766972
]
stack commented on HBASE-1915:
------------------------------
Chatted with Ryan on IRC patch...
Remove the DEBUG log that flags case where nothing to flush -- its going to get
annoying fast -- and 2., check optionalSync actually calls sync (I think it
does but looking at the patch only it may not).
Also, I ran the unit tests and it failed on HLog. Can you fix that?
If you do the above +1 on commit.
> HLog.sync is called way too often, needs to be only called 1x per RPC
> ---------------------------------------------------------------------
>
> Key: HBASE-1915
> URL: https://issues.apache.org/jira/browse/HBASE-1915
> Project: Hadoop HBase
> Issue Type: Bug
> Reporter: ryan rawson
> Assignee: ryan rawson
> Fix For: 0.21.0
>
> Attachments: HBASE-1915.patch
>
>
> fairly simple, we call sync every N KeyValues, even if they are from just 1
> row, you could be calling sync multiple times per row! that is just not good.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
