[ 
https://issues.apache.org/jira/browse/HBASE-2372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12849498#action_12849498
 ] 

Jean-Daniel Cryans commented on HBASE-2372:
-------------------------------------------

Another thing I'm not sure of is the reflection used in isAppend, it was useful 
when we supported both plain hadoop 0.20 and hadoop 0.20 + hdfs-200. Now this 
is not true for trunk since in SequenceFileLogWriter.sync we call syncFs, it 
wouldn't compile if hadoop wasn't patched.

Finally with trunk I think that if dfs.support.append is false, then we should 
not even boot.

> hbase trunk should check dfs.support.append and use append() to recovery 
> logfiles (as in branch)
> ------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-2372
>                 URL: https://issues.apache.org/jira/browse/HBASE-2372
>             Project: Hadoop HBase
>          Issue Type: Bug
>            Reporter: ryan rawson
>            Assignee: ryan rawson
>             Fix For: 0.21.0
>
>         Attachments: HBASE-2372.txt
>
>
> this is a backport of the feature in the hlog recovery where we call 
> fs.append(logfile); then fs.close() to recover a logfile in a situation where 
> we run with HDFS-200 (ie: dfs.support.append = true)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to