[ 
https://issues.apache.org/jira/browse/HBASE-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Spiegelberg updated HBASE-2382:
---------------------------------------

    Attachment: HBASE-2382-20.4.patch

Quick fix.  Ran 'ant -Dtestcase=TestLogRolling test', but I haven't setup a 
single instance cluster here.  I can set this up or you can verify it in your 
cluster.  I set the value for each writer so unit tests won't repeatedly roll 
when you have a 3-node cluster, you stop one datanode, and now your inital HLog 
replication is 2.

> Don't rely on fs.getDefaultReplication() to roll HLogs
> ------------------------------------------------------
>
>                 Key: HBASE-2382
>                 URL: https://issues.apache.org/jira/browse/HBASE-2382
>             Project: Hadoop HBase
>          Issue Type: Improvement
>            Reporter: Jean-Daniel Cryans
>            Assignee: Nicolas Spiegelberg
>             Fix For: 0.20.4, 0.21.0
>
>         Attachments: HBASE-2382-20.4.patch
>
>
> As I was commenting in HBASE-2234, using fs.getDefaultReplication() to roll 
> HLogs if they lose replicas isn't reliable since that value is client-side 
> and unless HBase is configured with it or has Hadoop's configurations on its 
> classpath, it will do the wrong thing.
> Dhruba added:
> bq. Can we use <hlogpath>.getFiletatus().getReplication() instead of 
> fs.getDefaltReplication()? This will will ensure that we look at the repl 
> factor of the precise file we are interested in, rather than what the 
> system-wide default value is.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to