[ 
https://issues.apache.org/jira/browse/HBASE-2438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12856977#action_12856977
 ] 

Jonathan Gray commented on HBASE-2438:
--------------------------------------

Patch looks good, just some nitpicks.

- Take out cleanup changes made to TestSingleColumnValueFilter (your patch 
otherwise does not touch this file so doesn't belong in this patch)
- TestColumnPaginationFilter has a copyright header from your company.  This 
should be removed and replaced with the apache license.
- ColumnPaginationFilter should be given an apache copyright header as well.

Otherwise, this looks good.  Haven't run unit tests yet but will try to get to 
that tonight.

Good stuff Paul.

> Addition of a Column Pagination Filter
> --------------------------------------
>
>                 Key: HBASE-2438
>                 URL: https://issues.apache.org/jira/browse/HBASE-2438
>             Project: Hadoop HBase
>          Issue Type: New Feature
>          Components: filters
>    Affects Versions: 0.20.3
>            Reporter: Paul Kist
>            Assignee: Paul Kist
>         Attachments: hbase-2438-0.20.3-v2.patch, hbase-2438-0.20.3.patch
>
>   Original Estimate: 8h
>  Remaining Estimate: 8h
>
> Client applications may need to do pagination, depending on the number of 
> columns returned, it may be more efficient to perform pagination algorithms 
> at the database level (similar to SQL's LIMIT and OFFSET).  This will be an 
> additional filter taking two parameters:
> - page
> - pageSize
> For every row, that gets returned, only a subset of columns are returned 
> based on page and pageSize
> If the page / pageSize column goes over the limits, then no results are 
> returned from the filter.
> A practical example for using a filter like this may be for folks doing 
> Row-based indexing with Hbase.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to