[
https://issues.apache.org/jira/browse/HBASE-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12864206#action_12864206
]
Benoit Sigoure commented on HBASE-2513:
---------------------------------------
Comments on v2 of the patch:
* Please indent the code properly.
** The way the condition of the {{switch}} statement is wrapped around looks
suspicious to me.
** The {{if}} statement on 1 line in {{process}}.
* In {{process}}, since you don't actually need the reference to the
{{HServerAddress}} of the root region, I think you should just pass a
{{boolean}} that indicates whether or not the root region is online (or,
alternatively, whether or not the "delayed todos" should be done first, as you
sort of tried to do in your first patch).
* If the root region is offline, the next thing we wanna do is bring it back
online. Are we guaranteed that the next {{poll}} on {{delayedToDoQueue}} will
give us this task? It seems your code assumes this but I'm not familiar enough
with it to confirm that it's the case.
> hbase-2414 added bug where we'd tight-loop if no root available.
> ----------------------------------------------------------------
>
> Key: HBASE-2513
> URL: https://issues.apache.org/jira/browse/HBASE-2513
> Project: Hadoop HBase
> Issue Type: Bug
> Reporter: stack
> Attachments: 2512-fix-for-2414-bug.patch, 2513-v2.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
