----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1197/#review1194 -----------------------------------------------------------
Ship it! I'm okay with shipping, patch addresses intent consistently, applies cleanly, compiles and all tests succeed. Thanks Francis! :) +1 /trunk/src/java/org/apache/hcatalog/mapreduce/HCatBaseInputFormat.java <https://reviews.apache.org/r/1197/#comment2603> (this segment could have been refactored out to a different function, I thought, because it's used elsewhere as well, and code duplication could be prevented, but this is a minor change, and not a problem) - Sushanth On 2011-07-26 23:11:17, Sushanth Sowmyan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1197/ > ----------------------------------------------------------- > > (Updated 2011-07-26 23:11:17) > > > Review request for hcatalog and Sushanth Sowmyan. > > > Summary > ------- > > Hcatalog-64 review request on behalf of Francis. > > > This addresses bug HCATALOG-64. > https://issues.apache.org/jira/browse/HCATALOG-64 > > > Diffs > ----- > > /trunk/src/java/org/apache/hcatalog/common/HCatUtil.java 1151189 > /trunk/src/java/org/apache/hcatalog/mapreduce/HCatBaseInputFormat.java > 1151189 > /trunk/src/java/org/apache/hcatalog/mapreduce/HCatBaseOutputFormat.java > 1151189 > /trunk/src/java/org/apache/hcatalog/mapreduce/HCatEximInputFormat.java > 1151189 > /trunk/src/java/org/apache/hcatalog/mapreduce/HCatEximOutputCommitter.java > 1151189 > /trunk/src/java/org/apache/hcatalog/mapreduce/HCatEximOutputFormat.java > 1151189 > /trunk/src/java/org/apache/hcatalog/mapreduce/HCatInputFormat.java 1151189 > /trunk/src/java/org/apache/hcatalog/mapreduce/HCatOutputCommitter.java > 1151189 > /trunk/src/java/org/apache/hcatalog/mapreduce/HCatOutputFormat.java 1151189 > /trunk/src/java/org/apache/hcatalog/mapreduce/HCatRecordWriter.java 1151189 > /trunk/src/java/org/apache/hcatalog/mapreduce/HCatTableInfo.java 1151189 > /trunk/src/java/org/apache/hcatalog/mapreduce/InitializeInput.java 1151189 > /trunk/src/java/org/apache/hcatalog/mapreduce/InputJobInfo.java > PRE-CREATION > /trunk/src/java/org/apache/hcatalog/mapreduce/JobInfo.java 1151189 > /trunk/src/java/org/apache/hcatalog/mapreduce/OutputJobInfo.java 1151189 > /trunk/src/java/org/apache/hcatalog/pig/HCatLoader.java 1151189 > /trunk/src/java/org/apache/hcatalog/pig/HCatStorer.java 1151189 > /trunk/src/java/org/apache/hcatalog/rcfile/RCFileInputDriver.java 1151189 > /trunk/src/test/org/apache/hcatalog/listener/TestNotificationListener.java > 1151189 > /trunk/src/test/org/apache/hcatalog/mapreduce/HCatMapReduceTest.java > 1151189 > /trunk/src/test/org/apache/hcatalog/mapreduce/TestHCatOutputFormat.java > 1151189 > > Diff: https://reviews.apache.org/r/1197/diff > > > Testing > ------- > > > Thanks, > > Sushanth > >
