[
https://issues.apache.org/jira/browse/HCATALOG-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13071436#comment-13071436
]
jirapos...@reviews.apache.org commented on HCATALOG-64:
-------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1197/#review1194
-----------------------------------------------------------
Ship it!
I'm okay with shipping, patch addresses intent consistently, applies cleanly,
compiles and all tests succeed. Thanks Francis! :)
+1
/trunk/src/java/org/apache/hcatalog/mapreduce/HCatBaseInputFormat.java
<https://reviews.apache.org/r/1197/#comment2603>
(this segment could have been refactored out to a different function, I
thought, because it's used elsewhere as well, and code duplication could be
prevented, but this is a minor change, and not a problem)
- Sushanth
On 2011-07-26 23:11:17, Sushanth Sowmyan wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1197/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-07-26 23:11:17)
bq.
bq.
bq. Review request for hcatalog and Sushanth Sowmyan.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Hcatalog-64 review request on behalf of Francis.
bq.
bq.
bq. This addresses bug HCATALOG-64.
bq. https://issues.apache.org/jira/browse/HCATALOG-64
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /trunk/src/java/org/apache/hcatalog/common/HCatUtil.java 1151189
bq. /trunk/src/java/org/apache/hcatalog/mapreduce/HCatBaseInputFormat.java
1151189
bq. /trunk/src/java/org/apache/hcatalog/mapreduce/HCatBaseOutputFormat.java
1151189
bq. /trunk/src/java/org/apache/hcatalog/mapreduce/HCatEximInputFormat.java
1151189
bq.
/trunk/src/java/org/apache/hcatalog/mapreduce/HCatEximOutputCommitter.java
1151189
bq. /trunk/src/java/org/apache/hcatalog/mapreduce/HCatEximOutputFormat.java
1151189
bq. /trunk/src/java/org/apache/hcatalog/mapreduce/HCatInputFormat.java
1151189
bq. /trunk/src/java/org/apache/hcatalog/mapreduce/HCatOutputCommitter.java
1151189
bq. /trunk/src/java/org/apache/hcatalog/mapreduce/HCatOutputFormat.java
1151189
bq. /trunk/src/java/org/apache/hcatalog/mapreduce/HCatRecordWriter.java
1151189
bq. /trunk/src/java/org/apache/hcatalog/mapreduce/HCatTableInfo.java 1151189
bq. /trunk/src/java/org/apache/hcatalog/mapreduce/InitializeInput.java
1151189
bq. /trunk/src/java/org/apache/hcatalog/mapreduce/InputJobInfo.java
PRE-CREATION
bq. /trunk/src/java/org/apache/hcatalog/mapreduce/JobInfo.java 1151189
bq. /trunk/src/java/org/apache/hcatalog/mapreduce/OutputJobInfo.java 1151189
bq. /trunk/src/java/org/apache/hcatalog/pig/HCatLoader.java 1151189
bq. /trunk/src/java/org/apache/hcatalog/pig/HCatStorer.java 1151189
bq. /trunk/src/java/org/apache/hcatalog/rcfile/RCFileInputDriver.java
1151189
bq.
/trunk/src/test/org/apache/hcatalog/listener/TestNotificationListener.java
1151189
bq. /trunk/src/test/org/apache/hcatalog/mapreduce/HCatMapReduceTest.java
1151189
bq. /trunk/src/test/org/apache/hcatalog/mapreduce/TestHCatOutputFormat.java
1151189
bq.
bq. Diff: https://reviews.apache.org/r/1197/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Sushanth
bq.
bq.
> Refactor HCatTableInfo, JobInfo and OutputJobInfo
> -------------------------------------------------
>
> Key: HCATALOG-64
> URL: https://issues.apache.org/jira/browse/HCATALOG-64
> Project: HCatalog
> Issue Type: Improvement
> Reporter: Francis Liu
> Assignee: Francis Liu
> Attachments: HCatTableInfo_JobInfo_OutputJobInfo_3.patch
>
>
> These classes and their roles has become convoluted. HCatTableInfo should be
> an HCat abstraction of table and thus not have any job specific information
> and should not contain different information depending on usage. *JobInfo
> classes should contain job specific information (user provided, derived from
> metastore info, etc). Since *JobInfo contains such information it should be
> the object which is passed to HCatInputFormat.setInput and
> HCatInputFormat.setOutput. Also JobInfo should be renamed to InputJobInfo for
> consistency and clarity. Also there needs to be a way to pass implementation
> specific configuration information down to the actual storage driver.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
