[
https://issues.apache.org/jira/browse/HCATALOG-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13083807#comment-13083807
]
Alan Gates commented on HCATALOG-64:
------------------------------------
So 1, 5, 6 we seem to have agreement.
On 2 (branching), once other issues are resolved I'm fine with checking this in
if we plan on using that tag as the branch point.
On 3 everyone seems to agree that what's in the patch is correct, so I'm good
with it.
On 4 I'm not trying to say you need to add arguments to setInput and setOutput.
I'm just trying to understand why InputJobFormat needs to know dbName and
tableName when it has a reference to an HCatTableInfo object that already knows
those values. Or does is this reference sometimes null?
On 7 Sushanth and Francis seem to be saying opposite things. We need to come
to agreement on this before we commit the patch.
> Refactor HCatTableInfo, JobInfo and OutputJobInfo
> -------------------------------------------------
>
> Key: HCATALOG-64
> URL: https://issues.apache.org/jira/browse/HCATALOG-64
> Project: HCatalog
> Issue Type: Improvement
> Affects Versions: 0.1, 0.2
> Reporter: Francis Liu
> Assignee: Francis Liu
> Fix For: 0.2
>
> Attachments: HCatTableInfo_JobInfo_OutputJobInfo_3.patch
>
>
> These classes and their roles has become convoluted. HCatTableInfo should be
> an HCat abstraction of table and thus not have any job specific information
> and should not contain different information depending on usage. *JobInfo
> classes should contain job specific information (user provided, derived from
> metastore info, etc). Since *JobInfo contains such information it should be
> the object which is passed to HCatInputFormat.setInput and
> HCatInputFormat.setOutput. Also JobInfo should be renamed to InputJobInfo for
> consistency and clarity. Also there needs to be a way to pass implementation
> specific configuration information down to the actual storage driver.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
