[ 
https://issues.apache.org/jira/browse/HCATALOG-148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141328#comment-13141328
 ] 

Thomas Weise commented on HCATALOG-148:
---------------------------------------

I also noticed that and agree that topic name resolution needs to be 
consistent. That would appear to be a separate JIRA. I only moved existing code 
to get a meaningful error message.

                
> Meaningful error message on failure to resolve topic name for partition event 
> ------------------------------------------------------------------------------
>
>                 Key: HCATALOG-148
>                 URL: https://issues.apache.org/jira/browse/HCATALOG-148
>             Project: HCatalog
>          Issue Type: Bug
>          Components: notification
>    Affects Versions: 0.2
>            Reporter: Thomas Weise
>            Assignee: Thomas Weise
>         Attachments: HCATALOG-148_branch-0.2.patch
>
>
> Topic name can be null if table was created prior to settings up JMS. Per 
> Ashutosh's comments:
> --
> NPE is certainly bad. We should do better. I think default may not be a good 
> idea. Lets give a better error message something of effect: "Topic name not 
> found in metastore. Please do alter table set properties 
> (topicname=dbname.tablename) or whatever you want topic name to be."
> --
> Ideally, this is transparent to user. If you look at onCreateTable() it puts 
> this in table properties while creating tables, so you need not to add it. If 
> you are running metastore configured with NotificationListener, createTable() 
> will auto populate this key-value. Looks like in this case, table was created 
> before notification was enabled. In that case, you need to add this key-value 
> pair yourself. To do it, you can do this via following ddl:
> ALTER TABLE table_name SET TBLPROPERTIES table_properties
> table_properties:
>   : (property_name = property_value, property_name = property_value, ... )

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to