[
https://issues.apache.org/jira/browse/HCATALOG-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145709#comment-13145709
]
[email protected] commented on HCATALOG-154:
--------------------------------------------------------
bq. On 2011-11-04 18:26:48, David Capwell wrote:
bq. > Can we have a test added that tests this change?
bq.
bq. Francis Liu wrote:
bq. Do you mean test that the correct outputdirectory is being used?
bq.
bq. David Capwell wrote:
bq. Well, the IOException used to get thrown before, would be nice to have
a test that gets the IOException to be thrown before the patch and make sure it
passes after, and another test that tries to get the new IOException to be
thrown (even though it shouldn't)
bq.
bq. Francis Liu wrote:
bq. Not sure what the difference is between the two tests you describe?
We should have a test that covers the old case and the new, if you can do that
in one test that is fine.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2727/#review3051
-----------------------------------------------------------
On 2011-11-07 18:46:21, Francis Liu wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2727/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-11-07 18:46:21)
bq.
bq.
bq. Review request for hcatalog, Sushanth Sowmyan, Vandana Ayyalasomayajula,
and David Capwell.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. fixed race condition and moved resolution outside of getOutputLocation
since output is intermediate.
bq.
bq.
bq. This addresses bug hcatalog-154.
bq. https://issues.apache.org/jira/browse/hcatalog-154
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseBaseOutputStorageDriver.java
989286f
bq.
storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseBulkOutputStorageDriver.java
9dfd238
bq.
storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseOutputStorageDriver.java
19ddd28
bq.
storage-drivers/hbase/src/test/org/apache/hcatalog/hbase/TestHBaseBulkOutputStorageDriver.java
c25e56d
bq.
bq. Diff: https://reviews.apache.org/r/2727/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. all unit tests pass.
bq.
bq.
bq. Thanks,
bq.
bq. Francis
bq.
bq.
> HBase bulkOSD and directOSD return inconsistent path for getOutputLocation()
> ----------------------------------------------------------------------------
>
> Key: HCATALOG-154
> URL: https://issues.apache.org/jira/browse/HCATALOG-154
> Project: HCatalog
> Issue Type: Bug
> Components: hbase
> Affects Versions: 0.3
> Reporter: David Capwell
> Assignee: Francis Liu
> Labels: hbase
> Fix For: 0.3
>
> Attachments: HCATALOG-154.patch
>
>
> org.apache.hcatalog.common.HCatException : 2001 : Error setting output
> information. Cause : java.io.IOException: bulkOSD and directOSD return
> inconsistent path for getOutputLocation()
> at
> org.apache.hcatalog.mapreduce.HCatOutputFormat.setOutput(HCatOutputFormat.java:257)
> ...
> at java.lang.Thread.run(Thread.java:619)
> Caused by: java.io.IOException: bulkOSD and directOSD return inconsistent
> path for getOutputLocation()
> at
> org.apache.hcatalog.hbase.HBaseOutputStorageDriver.getOutputLocation(HBaseOutputStorageDriver.java:52)
> at
> org.apache.hcatalog.mapreduce.HCatOutputFormat.setOutput(HCatOutputFormat.java:155)
> ... 24 more
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
