> On 2012-01-13 07:12:02, Francis Liu wrote: > > /trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseInputStorageDriver.java, > > line 105 > > <https://reviews.apache.org/r/2813/diff/5/?file=66169#file66169line105> > > > > need to update inputJobInfo stored in jobContext. > > Vandana Ayyalasomayajula wrote: > The only module which would need the updated input job info is the record > reader. It gets the updated one as I have the input job info as the member > variable. So do you think there can be anyone else who might be using the > snapshot ?
This value gets set the first time on the jobclient side but needs to be stored back into jobcontext so it gets passed to each of the job's tasks else all your record readers will be using new snapshots everytime. - Francis ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2813/#review4351 ----------------------------------------------------------- On 2012-01-03 18:07:56, Vandana Ayyalasomayajula wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2813/ > ----------------------------------------------------------- > > (Updated 2012-01-03 18:07:56) > > > Review request for hcatalog, Francis Liu and David Capwell. > > > Summary > ------- > > This patch contains the general changes required in hbase storage driver for > using revision manager. The actual integration between the read and write > side is still to be done. > > > This addresses bug hcatalog-191. > https://issues.apache.org/jira/browse/hcatalog-191 > > > Diffs > ----- > > > /trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseConstants.java > 1211611 > > /trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseHCatStorageHandler.java > 1211611 > > /trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseInputFormat.java > 1211611 > > /trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseInputStorageDriver.java > 1211611 > > /trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HbaseSnapshotRecordReader.java > PRE-CREATION > > /trunk/storage-drivers/hbase/src/test/org/apache/hcatalog/hbase/TestHBaseInputStorageDriver.java > 1211608 > > /trunk/storage-drivers/hbase/src/test/org/apache/hcatalog/hbase/TestSnapshots.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/2813/diff > > > Testing > ------- > > none. > > > Thanks, > > Vandana > >
