[
https://issues.apache.org/jira/browse/HCATALOG-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13202631#comment-13202631
]
[email protected] commented on HCATALOG-240:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3775/#review4867
-----------------------------------------------------------
src/java/org/apache/hadoop/mapred/HCatMapRedUtil.java
<https://reviews.apache.org/r/3775/#comment10704>
It seems odd to put this into the o.a.hadoop.mapred package. Are you
calling some package scoped function or something?
src/java/org/apache/hcatalog/common/HCatUtil.java
<https://reviews.apache.org/r/3775/#comment10708>
Some javadoc here on what should be passed into each of these values would
be helpful. They are class names I assume?
src/java/org/apache/hcatalog/common/HCatUtil.java
<https://reviews.apache.org/r/3775/#comment10709>
We shouldn't need code at all to pull out ISD and OSD info, since we're
removing them, correct? So I'm confused why a new function is being added here
to pull that info out.
src/java/org/apache/hcatalog/mapreduce/FileRecordWriterContainer.java
<https://reviews.apache.org/r/3775/#comment10723>
What is better that needs to be put here?
src/java/org/apache/hcatalog/mapreduce/FileRecordWriterContainer.java
<https://reviews.apache.org/r/3775/#comment10737>
We should add this before we commit the patch, as it should speed things up
quite a bit.
src/java/org/apache/hcatalog/mapreduce/FosterStorageHandler.java
<https://reviews.apache.org/r/3775/#comment10740>
Some javadoc on the purpose of this class would be good. I'm assuming the
purpose is to be a stand in StorageHandler in the HDFS storage case where there
isn't a storage handler.
Once we have moved getAuthorizationProvider from HCatStorageHandler to
HiveStorageHandler will this class extend HiveStorageHandler?
- Alan
On 2012-02-07 17:27:58, Francis Liu wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3775/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-07 17:27:58)
bq.
bq.
bq. Review request for hcatalog, Alan Gates and Sushanth Sowmyan.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. First drop. See HCATALOG-240.
bq.
bq.
bq. This addresses bug HCATALOG-240.
bq. https://issues.apache.org/jira/browse/HCATALOG-240
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/java/org/apache/hcatalog/mapreduce/FileOutputCommitterContainer.java
f37c5fd
bq. src/java/org/apache/hcatalog/mapreduce/DefaultOutputFormatContainer.java
13fa8ac
bq. src/java/org/apache/hcatalog/mapreduce/DefaultRecordWriterContainer.java
7c90737
bq.
src/java/org/apache/hcatalog/mapreduce/DefaultOutputCommitterContainer.java
9c5fdd3
bq. src/java/org/apache/hadoop/mapred/HCatMapRedUtil.java PRE-CREATION
bq. src/java/org/apache/hcatalog/cli/SemanticAnalysis/CreateTableHook.java
9d98f50
bq. src/java/org/apache/hcatalog/common/HCatUtil.java 13b56fd
bq. src/java/org/apache/hcatalog/mapreduce/FileOutputFormatContainer.java
e91ed0f
bq. src/java/org/apache/hcatalog/mapreduce/FileOutputStorageDriver.java
6596264
bq. src/java/org/apache/hcatalog/mapreduce/FileRecordWriterContainer.java
c72cb4f
bq. src/java/org/apache/hcatalog/mapreduce/FosterStorageHandler.java
PRE-CREATION
bq. src/java/org/apache/hcatalog/mapreduce/HCatBaseOutputFormat.java 1b2f9a4
bq. src/java/org/apache/hcatalog/mapreduce/HCatEximInputFormat.java 90c5671
bq. src/java/org/apache/hcatalog/mapreduce/HCatEximInputFormat.java.broken
PRE-CREATION
bq. src/java/org/apache/hcatalog/mapreduce/HCatEximOutputCommitter.java
1ba8ccd
bq.
src/java/org/apache/hcatalog/mapreduce/HCatEximOutputCommitter.java.broken
PRE-CREATION
bq. src/java/org/apache/hcatalog/mapreduce/HCatEximOutputFormat.java ed1ba66
bq. src/java/org/apache/hcatalog/mapreduce/HCatEximOutputFormat.java.broken
PRE-CREATION
bq. src/java/org/apache/hcatalog/mapreduce/HCatOutputFormat.java d7eab9e
bq. src/java/org/apache/hcatalog/mapreduce/HCatOutputStorageDriver.java
566943f
bq. src/java/org/apache/hcatalog/mapreduce/HCatStorageHandler.java
PRE-CREATION
bq. src/java/org/apache/hcatalog/mapreduce/HCatTableInfo.java e65f1d0
bq. src/java/org/apache/hcatalog/mapreduce/OutputCommitterContainer.java
5f0585a
bq. src/java/org/apache/hcatalog/mapreduce/OutputFormatContainer.java
f73a6dc
bq. src/java/org/apache/hcatalog/mapreduce/OutputJobInfo.java 9830190
bq. src/java/org/apache/hcatalog/mapreduce/ProgressReporter.java
PRE-CREATION
bq. src/java/org/apache/hcatalog/mapreduce/RecordWriterContainer.java
9a93bfa
bq. src/java/org/apache/hcatalog/mapreduce/StorerInfo.java 8785ffb
bq. src/java/org/apache/hcatalog/pig/HCatEximLoader.java a36f808
bq. src/java/org/apache/hcatalog/pig/HCatEximLoader.java.broken PRE-CREATION
bq. src/java/org/apache/hcatalog/pig/HCatEximStorer.java b7bee44
bq. src/java/org/apache/hcatalog/pig/HCatEximStorer.java.broken PRE-CREATION
bq. src/test/org/apache/hcatalog/cli/DummyStorageHandler.java 0e9565c
bq. src/test/org/apache/hcatalog/cli/TestStorageHandlerProperties.java
df8f5a5
bq.
src/test/org/apache/hcatalog/cli/TestStorageHandlerProperties.java.broken
PRE-CREATION
bq. src/test/org/apache/hcatalog/mapreduce/TestHCatEximInputFormat.java
9d94c7b
bq.
src/test/org/apache/hcatalog/mapreduce/TestHCatEximInputFormat.java.broken
PRE-CREATION
bq. src/test/org/apache/hcatalog/mapreduce/TestHCatEximOutputFormat.java
99ec02b
bq.
src/test/org/apache/hcatalog/mapreduce/TestHCatEximOutputFormat.java.broken
PRE-CREATION
bq. src/test/org/apache/hcatalog/mapreduce/TestHCatOutputFormat.java 5df0146
bq. src/test/org/apache/hcatalog/pig/TestHCatEximLoader.java 7691fb9
bq. src/test/org/apache/hcatalog/pig/TestHCatEximLoader.java.broken
PRE-CREATION
bq. src/test/org/apache/hcatalog/pig/TestHCatEximStorer.java c3ba19d
bq. src/test/org/apache/hcatalog/pig/TestHCatEximStorer.java.broken
PRE-CREATION
bq. storage-drivers/build.xml efd26d0
bq.
bq. Diff: https://reviews.apache.org/r/3775/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Francis
bq.
bq.
> Changes to HCatOutputFormat to make it use SerDes instead of StorageDriver
> --------------------------------------------------------------------------
>
> Key: HCATALOG-240
> URL: https://issues.apache.org/jira/browse/HCATALOG-240
> Project: HCatalog
> Issue Type: Sub-task
> Components: storage handlers
> Affects Versions: 0.4
> Reporter: Alan Gates
> Assignee: Francis Liu
> Fix For: 0.4
>
> Attachments: HCATALOG-240.patch
>
>
> This JIRA covers changes to HCatOutputFormat, OutputJobInfo, and
> HCatOutputCommitter. See HCATALOG-237 for design notes and details.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
