[ 
https://issues.apache.org/jira/browse/HCATALOG-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209920#comment-13209920
 ] 

[email protected] commented on HCATALOG-262:
--------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3941/
-----------------------------------------------------------

Review request for Francis Liu and Vandana Ayyalasomayajula.


Summary
-------

Made the HbaseSnapshotRecordReader ignore aborted transactions. 

OutputCommitter's already had code for aborting the transaction on job failure. 
 Just added unit tests for it. 


This addresses bug HCATALOG-262.
    https://issues.apache.org/jira/browse/HCATALOG-262


Diffs
-----

  
http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.3/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseBaseOutputStorageDriver.java
 1244740 
  
http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.3/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseInputFormat.java
 1244740 
  
http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.3/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseInputStorageDriver.java
 1244740 
  
http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.3/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HbaseSnapshotRecordReader.java
 1244740 
  
http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.3/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/snapshot/FamilyRevision.java
 1244740 
  
http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.3/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/snapshot/RevisionManager.java
 1244740 
  
http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.3/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/snapshot/ZKBasedRevisionManager.java
 1244740 
  
http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.3/storage-drivers/hbase/src/test/org/apache/hcatalog/hbase/TestHBaseBulkOutputStorageDriver.java
 1244740 
  
http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.3/storage-drivers/hbase/src/test/org/apache/hcatalog/hbase/TestHBaseDirectOutputStorageDriver.java
 1244740 
  
http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.3/storage-drivers/hbase/src/test/org/apache/hcatalog/hbase/TestHBaseInputStorageDriver.java
 1244740 

Diff: https://reviews.apache.org/r/3941/diff


Testing
-------

Unit tests added


Thanks,

Rohini


                
> Invalidation of Failed Write Transactions in HBase Input and OutputFormats
> --------------------------------------------------------------------------
>
>                 Key: HCATALOG-262
>                 URL: https://issues.apache.org/jira/browse/HCATALOG-262
>             Project: HCatalog
>          Issue Type: Bug
>          Components: hbase
>    Affects Versions: 0.3
>            Reporter: Rohini Palaniswamy
>            Priority: Minor
>              Labels: hbase
>             Fix For: 0.3
>
>
> HBaseDirectOutputFormat and HBaseBulkOutputFormat abort transactions on job 
> failure. HbaseSnapshotRecordReader should ignore the aborted transactions 
> while reading from HBase. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to